Skip to content

[Java][Rest-assured] Changed Rest-assured params#91

Merged
jmini merged 1 commit intoOpenAPITools:masterfrom
viclovsky:ra_params
May 18, 2018
Merged

[Java][Rest-assured] Changed Rest-assured params#91
jmini merged 1 commit intoOpenAPITools:masterfrom
viclovsky:ra_params

Conversation

@viclovsky
Copy link
Contributor

@viclovsky viclovsky commented May 17, 2018

…een refactored

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Added constants for Rest-assured params.
Made params as constants for Rest-assured.
See issue.

@viclovsky viclovsky changed the title CaseFormatLambda has been added, params for Rest-assured client has b… [Rest-assured] Consts for params has been added May 17, 2018
@viclovsky viclovsky changed the title [Rest-assured] Consts for params has been added [Rest-assured] Changed Rest-assured params May 17, 2018
@viclovsky viclovsky changed the title [Rest-assured] Changed Rest-assured params [Java][Rest-assured] Changed Rest-assured params May 17, 2018
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it not be reqSpec.addQueryParam(QUERY_QUERY, query); ??

@jmini
Copy link
Member

jmini commented May 17, 2018

I like this a lot. Thank you!

Can it be that your update of rest-assured in samples/ was not made with the latest template?

@viclovsky
Copy link
Contributor Author

viclovsky commented May 17, 2018

Can it be that your update of rest-assured in samples/ was not made with the latest template?

Yep, just updated, thanks.

@jmini
Copy link
Member

jmini commented May 18, 2018

I tested:

mvn clean verify -f samples/client/petstore/java/rest-assured/pom.xml

And I generated a rest assured client with my spec.

Looks good to me.

@jmini jmini merged commit 3b9a2a7 into OpenAPITools:master May 18, 2018
@jmini jmini added this to the 3.0.0 milestone May 18, 2018
jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request May 23, 2018
* master: (36 commits)
  jaxrs-cxf-cdi: fix outer enum (OpenAPITools#131)
  Move bash argv opt to end of ags line in scripts (OpenAPITools#124)
  Reduce CI logging (OpenAPITools#119)
  Download elm dependencies without prompting user. (OpenAPITools#118)
  [aspnetcore] Make the use of Swashbuckle optional (OpenAPITools#110)
  DefaultGenerator: fix NullPointerException (OpenAPITools#109)
  [Java] use html entities in javadoc of generated code (OpenAPITools#106)
  Update PULL_REQUEST_TEMPLATE.md
  [java] Enum in array of array (OpenAPITools#66)
  Rename datatype to dataType in CodegenProperty (OpenAPITools#69)
  update elm test to compile all elm files (OpenAPITools#95)
  Fix Petstore example for Elm (OpenAPITools#96)
  Update Docker documentation (OpenAPITools#97)
  CaseFormatLambda has been added, params for Rest-assured client has been refactored (OpenAPITools#91)
  Update integration.md
  [Clojure] Add util method to set the api-context globally (OpenAPITools#93)
  [JaxRS-Java] issue with implFolder on windows, and required fields generation for containers (OpenAPITools#88)
  Set parameters allowableValues dynamically (OpenAPITools#65)
  Meta: set version for "build-helper-maven-plugin" (OpenAPITools#89)
  Fix javadoc issues in "openapi-generator" module (OpenAPITools#84)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants