feat(typescript-axios): injectable FormData#7455
Merged
macjohnny merged 1 commit intoOpenAPITools:masterfrom Sep 21, 2020
Merged
feat(typescript-axios): injectable FormData#7455macjohnny merged 1 commit intoOpenAPITools:masterfrom
macjohnny merged 1 commit intoOpenAPITools:masterfrom
Conversation
Signed-off-by: Peter Somogyvari <peter.metz@unarin.com>
6 tasks
sapphi-red
added a commit
to sapphi-red/openapi-generator
that referenced
this pull request
Sep 22, 2020
To avoid requiring TypeScript above 3.7.2. refs OpenAPITools#7455
macjohnny
pushed a commit
that referenced
this pull request
Sep 25, 2020
To avoid requiring TypeScript above 3.7.2. refs #7455
fgnass
pushed a commit
to oazapfts/oazapfts
that referenced
this pull request
Mar 5, 2021
* Allow to return blob for binary data * Generic param not needed * Deduplicate * Improve return type heuristic * Assume text for content type "text/*" * Assume text for empty responses (backwards-compatbility) * Rest will map to Blob * Consolidate functions to determine response type * Ensure proper typing for optimistic API * Improve result type detection * Allow to customize FormData constructor Inspired by * OpenAPITools/openapi-generator#7455 * OpenAPITools/openapi-generator#2939 * Fix defaults.formDataConstructor * || instead of ??
phryneas
pushed a commit
to phryneas/oazapfts
that referenced
this pull request
Mar 5, 2021
* Allow to return blob for binary data * Generic param not needed * Deduplicate * Improve return type heuristic * Assume text for content type "text/*" * Assume text for empty responses (backwards-compatbility) * Rest will map to Blob * Consolidate functions to determine response type * Ensure proper typing for optimistic API * Improve result type detection * Allow to customize FormData constructor Inspired by * OpenAPITools/openapi-generator#7455 * OpenAPITools/openapi-generator#2939 * Fix defaults.formDataConstructor * || instead of ?? (cherry picked from commit cf90725)
fgnass
added a commit
to oazapfts/oazapfts
that referenced
this pull request
Mar 5, 2021
* convert generateApi function to class * add reset method * export methods * update TS to 4.1.2 * cleanup, make some properties public * fix: remove special chars (closes #42, #48) (cherry picked from commit 25d67ba) * feat(#52): support Blobs * Allow to return blob for binary data * Generic param not needed * Deduplicate * Improve return type heuristic * Assume text for content type "text/*" * Assume text for empty responses (backwards-compatbility) * Rest will map to Blob * Consolidate functions to determine response type * Ensure proper typing for optimistic API * Improve result type detection * Allow to customize FormData constructor Inspired by * OpenAPITools/openapi-generator#7455 * OpenAPITools/openapi-generator#2939 * Fix defaults.formDataConstructor * || instead of ?? (cherry picked from commit cf90725) Co-authored-by: Felix Gnass <fgnass@gmail.com> Co-authored-by: Philipp Katz <philipp@philippkatz.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peter Somogyvari peter.metz@unarin.com
Added an optional parameter to the constructor parameters of the
Configurationclass so that a user defindFormDataconstructor can be injected in execution environments whereFormDatais not supported by default (e.g. NodeJS).This issue is tracking the same problem which I also had and thus this PR was born:
#2939
I tested it by using the generator on a project I'm a maintainer of where we use the tool (thank you very much for the all your work)
What this enables is code like this in my NodeJS test cases:
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.mastercc technical committee for Typescript and NodeJS:
@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)
@CodeNinjai (2017/07) @frol (2017/07) @cliffano (2017/07)