[Slim] Add PHP CodeSniffer config template#1764
Merged
ackintosh merged 5 commits intoOpenAPITools:masterfrom Dec 29, 2018
Merged
[Slim] Add PHP CodeSniffer config template#1764ackintosh merged 5 commits intoOpenAPITools:masterfrom
ackintosh merged 5 commits intoOpenAPITools:masterfrom
Conversation
PHPUnit and PHP_CodeSniffer provides the same developing pattern when user overrides global config with local one. In local config he can set environment variables. Official doc recommends to not commit local config files.
Now user have full freedom to override config file. This option is not used and not necessary anymore.
ackintosh
approved these changes
Dec 29, 2018
jimschubert
added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Dec 31, 2018
* master: (26 commits) Delete unused method (OpenAPITools#1744) Use JsonNullable wrapper on nullable/x-nullable fields (OpenAPITools#1762) Add an option to use reflection in equals, hashCode (Java client) (OpenAPITools#1767) [Slim] Encode path to support non-latin characters (OpenAPITools#1687) [elm] Add support for sending headers (OpenAPITools#1704) Add test case for InlineModelResolver: inline array response (OpenAPITools#1778) fix group parameter logic (OpenAPITools#1779) Add test case for InlineModelResolver: inline array request body (OpenAPITools#1777) Add test case for InlineModelResolver: inline array schema (OpenAPITools#1772) Fix type inference error (OpenAPITools#1773) skip default value for contaier in spring (OpenAPITools#1725) [Slim] Add PHP CodeSniffer config template (OpenAPITools#1764) Use CompareNetObject for object comparison in C# client (refactor) (OpenAPITools#1765) Add test case for InlineModelResolver (OpenAPITools#1771) Add online gen tests (OpenAPITools#1759) Resolve inline models before preprocess (OpenAPITools#1761) better handling of allOf (composition) (OpenAPITools#1757) Fix UUID support (OpenAPITools#1746) Use appInfo.version for podspec (OpenAPITools#1760) [Swift 4] Add `createURLRequest` method (OpenAPITools#1727) ...
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* [Slim] Add PHP_CodeSniffer config template * [Slim] Update doc * [Slim] Add local configs to gitignore PHPUnit and PHP_CodeSniffer provides the same developing pattern when user overrides global config with local one. In local config he can set environment variables. Official doc recommends to not commit local config files. * [Slim] Remove phpcsStandard CLI option Now user have full freedom to override config file. This option is not used and not necessary anymore. * [Slim] Refresh samples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
Recommended way to configure PHP CodeSniffer:
Ref: Using a Default Configuration File
Generator cli option
phpcsStandardis deprecated as not necessary anymore.Upgrade note
Do not use
phpcsStandardcli option during server stubs generation.Override
phpcs.xml.distin root folder withphpcs.xmlto change config.