[JAVA] [WebClient] Handle list of String special case in WebClient generator#14125
Closed
GavinWu1991 wants to merge 4 commits intoOpenAPITools:masterfrom
Closed
[JAVA] [WebClient] Handle list of String special case in WebClient generator#14125GavinWu1991 wants to merge 4 commits intoOpenAPITools:masterfrom
GavinWu1991 wants to merge 4 commits intoOpenAPITools:masterfrom
Conversation
Contributor
Author
|
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) |
thomaskrause
added a commit
to korpling/ANNIS
that referenced
this pull request
Dec 9, 2022
…of strings as mono. If OpenAPITools/openapi-generator#14125 gets merged, we won't need this workaround anymore
|
Please follow through with this. Trying to push reactive at my current customer and this issue has been causing a lot of push-back. |
b9d4d56 to
d3b2c44
Compare
d3b2c44 to
ac846ed
Compare
|
As someone whose team just ran into this, we'd love to see this merged. |
6 tasks
Member
|
merged via #16326 instead with an additional fix in api_test.mustache |
Member
|
@domizei385 @tildedave feel free to sponsor @GavinWu1991 directly for this fix 🙏 Thanks @GavinWu1991 again for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When describing an operation that returns an array of strings, the openapi-generator for java-webclient generates an API returning the array of strings in a single string.
The PR contains the change that will generate the API client of the operation that returns an array of strings to Mono<List> instead of Flux.
Close: #7118
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)