Skip to content

Specify source encoding in java/kotlin sample poms templates#12088

Merged
wing328 merged 2 commits intomasterfrom
cghislai-sample-tests-file-encoding
Apr 9, 2022
Merged

Specify source encoding in java/kotlin sample poms templates#12088
wing328 merged 2 commits intomasterfrom
cghislai-sample-tests-file-encoding

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Apr 9, 2022

Add the <project.build.sourceEncoding> property in some templates, so that the sample tests can be run independently of the host default file encoding.

Based on #11477

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)

@cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02)

@jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03)

@wing328 wing328 added this to the 6.0.0 milestone Apr 9, 2022
@wing328 wing328 merged commit 6bc065e into master Apr 9, 2022
@wing328 wing328 deleted the cghislai-sample-tests-file-encoding branch April 9, 2022 07:21
cachescrubber pushed a commit to cachescrubber/openapi-generator that referenced this pull request Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants