[Python] Fix incorrectly capitalized mustache identifier in apis template#12045
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Apr 5, 2022
harmony7:ruby-apis-template-fix
Merged
[Python] Fix incorrectly capitalized mustache identifier in apis template#12045wing328 merged 1 commit intoOpenAPITools:masterfrom harmony7:ruby-apis-template-fix
wing328 merged 1 commit intoOpenAPITools:masterfrom
harmony7:ruby-apis-template-fix
Conversation
Contributor
Author
|
Hi, the CI is giving problems in the "samples up-to-date" step. The details reveal a problem with a completely unrelated file, so I don't think this is a problem on my end. Can someone check the status of this for me? thanks. |
Member
I've fixed that in the master. Your PR looks good. Thanks for that. |
Member
|
cc @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @arun-nalla (2019/11) @spacether (2019/11) ❤️ |
Contributor
Author
|
Yes of course this is Python. I got confused I guess, have been using different generators one after the other. Thanks for the approval and merge, cheers =) |
cachescrubber
pushed a commit
to cachescrubber/openapi-generator
that referenced
this pull request
Apr 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tiny PR fixes the spelling of an identifier that was incorrectly cased in a mustache template. The fix only affects a comment in the output, so it will make no runtime difference when consuming a generated client.
In the Python generator, the package name is available as
{{packageName}}, but insrc/main/resources/python/__init__apis.mustache, it was being referenced as{{packagename}}.This produced incorrect output such as:
(note the missing package name)
The corrected output:
cc @cliffano @zlx @autopp
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.