Skip to content

[java][okhttp-gson] Better checks in validateJsonObject#12041

Merged
wing328 merged 1 commit intomasterfrom
better-json-check
Apr 5, 2022
Merged

[java][okhttp-gson] Better checks in validateJsonObject#12041
wing328 merged 1 commit intomasterfrom
better-json-check

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Apr 4, 2022

  • Better checks (e.g. array type check) in validateJsonObject
  • Add tests

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)

@wing328 wing328 added this to the 6.0.0 milestone Apr 4, 2022
@wing328 wing328 merged commit 4e16146 into master Apr 5, 2022
@wing328 wing328 deleted the better-json-check branch April 5, 2022 09:24
cachescrubber pushed a commit to cachescrubber/openapi-generator that referenced this pull request Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant