Process additionalProperties: true as arbitrary type instead of object#11802
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Apr 9, 2022
puppetlabs:fix-additional-properties-any-type
Merged
Process additionalProperties: true as arbitrary type instead of object#11802wing328 merged 1 commit intoOpenAPITools:masterfrom puppetlabs:fix-additional-properties-any-type
wing328 merged 1 commit intoOpenAPITools:masterfrom
puppetlabs:fix-additional-properties-any-type
Conversation
When a schema specifies additionalProperties: true, we need not restrict those properties to a particular type. This change sets the schemas for them to AnyType instead of object. From a generation perspective, this only changes the output for generators that differentiate between AnyType and object in their type mappings; most do not. This fixes at least one bug in the Go and TypeScript generators.
Member
|
Tested locally and the result is good. Thanks for the PR FYI @OpenAPITools/generator-core-team |
cachescrubber
pushed a commit
to cachescrubber/openapi-generator
that referenced
this pull request
Apr 9, 2022
When a schema specifies additionalProperties: true, we need not restrict those properties to a particular type. This change sets the schemas for them to AnyType instead of object. From a generation perspective, this only changes the output for generators that differentiate between AnyType and object in their type mappings; most do not. This fixes at least one bug in the Go and TypeScript generators.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a schema specifies
additionalProperties: true, we need not restrict those properties to a particular type. This change sets the schemas for them toAnyTypeinstead ofobject.From a generation perspective, this only changes the output for generators that differentiate between
AnyTypeandobjectin their type mappings; most do not. This fixes at least one bug in the Go and TypeScript generators.New tests for the Go generator and
DefaultCodegendemonstrate the intent of this change.PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.xFor Go, @antihax @grokify @kemokemo @jirikuncar @ph4r5h4d
For TypeScript, @TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero
Thanks in advance for the review!