Skip to content

Add no_proxy support to python client#10648

Merged
tomplus merged 6 commits intoOpenAPITools:masterfrom
itaru2622:noproxy_support_pycli
Oct 26, 2021
Merged

Add no_proxy support to python client#10648
tomplus merged 6 commits intoOpenAPITools:masterfrom
itaru2622:noproxy_support_pycli

Conversation

@itaru2622
Copy link
Copy Markdown
Contributor

@itaru2622 itaru2622 commented Oct 20, 2021 •
edited
Loading

close #10647

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@taxpon @frol @mbohlool @cbornet @kenjones-cisco @tomplus @Jyhess @arun-nalla @spacether @wing328

@itaru2622 itaru2622 force-pushed the noproxy_support_pycli branch from f575e47 to 43dbd1f Compare October 20, 2021 15:39
@itaru2622
Copy link
Copy Markdown
Contributor Author

itaru2622 commented Oct 20, 2021 •
edited
Loading

hmm... why ci/circleci test failed in typescript even my PR is just for python client.

log line 5023 in ./CI/circle_parallel.sh phase.

Run `npm audit` for details.

> typescript-angular-v7-unit-tests@0.0.0 test
> ng test "--progress=false" "--no-watch" "--browsers" "ChromeHeadless"

20 10 2021 16:43:58.004:INFO [karma]: Karma v3.0.0 server started at http://0.0.0.0:9876/
20 10 2021 16:43:58.007:INFO [launcher]: Launching browser ChromeHeadless with unlimited concurrency
20 10 2021 16:43:58.012:INFO [launcher]: Starting browser ChromeHeadless
20 10 2021 16:43:58.116:ERROR [karma]: Error: error:0308010C:digital envelope routines::unsupported
   at new Hash (node:internal/crypto/hash:67:19)
    at Object.createHash (node:crypto:130:10)
    at module.exports (/home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/typescript-angular-v7-provided-in-root/node_modules/webpack/lib/util/createHash.js:90:53)
    at NormalModule._initBuildHash (/home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/typescript-angular-v7-provided-in-root/node_modules/webpack/lib/NormalModule.js:386:16)
    at /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/typescript-angular-v7-provided-in-root/node_modules/webpack/lib/NormalModule.js:418:10
    at /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/typescript-angular-v7-provided-in-root/node_modules/webpack/lib/NormalModule.js:293:13
    at /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/typescript-angular-v7-provided-in-root/node_modules/loader-runner/lib/LoaderRunner.js:364:11
    at /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/typescript-angular-v7-provided-in-root/node_modules/loader-runner/lib/LoaderRunner.js:200:19
    at VirtualFileSystemDecorator.readFile (/home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/typescript-angular-v7-provided-in-root/node_modules/@ngtools/webpack/src/packages/ngtools/webpack/src/virtual_file_system_decorator.ts:50:7)
    at processResource (/home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/typescript-angular-v7-provided-in-root/node_modules/loader-runner/lib/LoaderRunner.js:199:11)
    at iteratePitchingLoaders (/home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/typescript-angular-v7-provided-in-root/node_modules/loader-runner/lib/LoaderRunner.js:158:10)
    at runLoaders (/home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/typescript-angular-v7-provided-in-root/node_modules/loader-runner/lib/LoaderRunner.js:362:2)
    at NormalModule.doBuild (/home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/typescript-angular-v7-provided-in-root/node_modules/webpack/lib/NormalModule.js:265:3)
    at NormalModule.build (/home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/typescript-angular-v7-provided-in-root/node_modules/webpack/lib/NormalModule.js:412:15)
    at Compilation.buildModule (/home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/typescript-angular-v7-provided-in-root/node_modules/webpack/lib/Compilation.js:626:10)
    at /home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/typescript-angular-v7-provided-in-root/node_modules/webpack/lib/Compilation.js:875:14 {
  opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'
}

@itaru2622 itaru2622 force-pushed the noproxy_support_pycli branch from b6c512a to 573fcf4 Compare October 20, 2021 23:41
@itaru2622 itaru2622 mentioned this pull request Oct 21, 2021
Merged
@itaru2622
Copy link
Copy Markdown
Contributor Author

itaru2622 commented Oct 21, 2021

@taxpon @frol @mbohlool @cbornet @kenjones-cisco @tomplus @Jyhess @arun-nalla @spacether @wing328

finally CI test passed. could you review this PR, please.

@itaru2622 itaru2622 force-pushed the noproxy_support_pycli branch 2 times, most recently from aa1ad3a to 005b46b Compare October 24, 2021 15:45
@itaru2622
Copy link
Copy Markdown
Contributor Author

itaru2622 commented Oct 24, 2021

hmm... It seems to need rebase against latest master to pass CI tests...

@tomplus
Copy link
Copy Markdown
Member

tomplus commented Oct 24, 2021

LGTM 👍

Please fix reported problems.

@itaru2622 itaru2622 force-pushed the noproxy_support_pycli branch from 005b46b to f8a0d65 Compare October 25, 2021 01:50
@itaru2622
Copy link
Copy Markdown
Contributor Author

itaru2622 commented Oct 25, 2021

@tomplus problems are fixed and all CI test passed. could you review this PR, please.

@tomplus tomplus added this to the 5.3.1 milestone Oct 26, 2021
@tomplus tomplus merged commit 97e079f into OpenAPITools:master Oct 26, 2021
@tomplus
Copy link
Copy Markdown
Member

tomplus commented Oct 26, 2021

@itaru2622 Thanks for your contribution 👍

@itaru2622 itaru2622 deleted the noproxy_support_pycli branch October 26, 2021 13:03
@wing328 wing328 changed the title add no_proxy support to python client dd no_proxy support to python client Dec 19, 2021
@wing328 wing328 changed the title dd no_proxy support to python client Add no_proxy support to python client Dec 19, 2021
@bachorp bachorp mentioned this pull request Jun 7, 2025
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomplus tomplus tomplus approved these changes

Assignees

No one assigned

Labels

Client: Python Enhancement: General

Projects

None yet

Milestone

5.3.1

Development

Successfully merging this pull request may close these issues.

[REQ] add no_proxy support to python client

3 participants

@itaru2622 @tomplus @wing328