Modeling - Enhance periodic curve handling in ChFi3d_Builder#892
Modeling - Enhance periodic curve handling in ChFi3d_Builder#892dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
Conversation
dpasukhi
commented
Dec 7, 2025
- Updated the intersection logic to check for non-null C2dint1 when determining periodicity of 3D curves.
- Improved robustness of the PerformIntersectionAtEnd function to prevent potential issues with null parameters.
…scade-SAS#892) - Updated the intersection logic to check for non-null C2dint1 when determining periodicity of 3D curves. - Improved robustness of the PerformIntersectionAtEnd function to prevent potential issues with null parameters.
Update private test reports after Open-Cascade-SAS#892 Open-Cascade-SAS#890 Open-Cascade-SAS#894 Open-Cascade-SAS#889
|
Thanks for this PR! Although there is no longer a crash as described in #690, the blend doesn't result in correct geometry, which is visible in DRAW and in FreeCAD:
Below a transcript in DRAW with some checks where Possibly the other related issues give some more handles to investigate. |
|
Yes, the output is not valid. The issue were related to crash. |
|
Totally understand. The PR fixes the crash, so the original issue can be closed. Sure, I've already investigated, so it's easy for me to create a new issue for the quality. |
