Modelling - Boolean fuse segfaults on loft#860
Merged
dpasukhi merged 2 commits intoOpen-Cascade-SAS:IRfrom Nov 29, 2025
Merged
Conversation
BOPAlgo_PaveFiller::FillPaves() and CorrectWires() are now skipping edges without geometry. Minor refactoring of some functions in BOPAlgo_PaveFiller is performed.
There was a problem hiding this comment.
Pull request overview
This PR fixes a segmentation fault that occurred during Boolean fuse operations on lofted shapes. The fix adds null checks for edge geometry in two critical functions: FillPaves() and CorrectWires(), preventing crashes when encountering edges without associated geometric curves. Additionally, the code includes refactoring improvements to BOPAlgo_PaveFiller::ProcessDE() and FindPaveBlocks() for better readability and modern C++ practices.
Key changes:
- Added null checks for 2D curve handles to prevent dereferencing null geometry
- Refactored
ProcessDE()to use modern C++ idioms (auto, structured bindings, range-based iteration patterns) - Simplified
FindPaveBlocks()using a lambda function to reduce code duplication
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| BOPTools_AlgoTools_1.cxx | Added null check for 2D curve before parameter extraction in CorrectWires() |
| BOPAlgo_PaveFiller_8.cxx | Added null check in FillPaves(), refactored ProcessDE() and FindPaveBlocks() for cleaner code structure |
Member
|
New test crash SEGFAL on old version with new fixed. |
dpasukhi
approved these changes
Nov 29, 2025
dpasukhi
pushed a commit
to dpasukhi/OCCT
that referenced
this pull request
Dec 5, 2025
- Added null checks for 2D curve handles to prevent dereferencing null geometry - Refactored `ProcessDE()` to use modern C++ idioms (auto, structured bindings, range-based iteration patterns) - Simplified `FindPaveBlocks()` using a lambda function to reduce code duplication
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BOPAlgo_PaveFiller::FillPaves() and CorrectWires() are now skipping edges without geometry.
Minor refactoring of some functions in BOPAlgo_PaveFiller is performed.