Modeling, BSplineCache - Improve parameter validation logic#829
Merged
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom Nov 17, 2025
Merged
Modeling, BSplineCache - Improve parameter validation logic#829dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
Conversation
Member
dpasukhi
commented
Nov 13, 2025
- Enhanced the parameter validation logic in BSplCLib_CacheParams to ensure correct handling of edge cases.
- Added checks for floating point precision when determining if the next knot should be used.
- Improved code readability by restructuring the return conditions.
There was a problem hiding this comment.
Pull Request Overview
The PR enhances parameter validation logic in BSplCLib_CacheParams to improve handling of edge cases in B-spline curve parameter validation. The changes focus on adding floating-point precision checks when determining whether a parameter falls within the current span or should use the next knot.
Key Changes:
- Restructured the return logic from a single compound boolean expression into multiple explicit conditional checks
- Added floating-point precision validation to detect when a parameter is effectively at the next knot boundary
- Improved code readability by separating edge case handling from the main validation logic
dpasukhi
pushed a commit
to dpasukhi/OCCT
that referenced
this pull request
Nov 17, 2025
…ade-SAS#829 - Enhanced the parameter validation logic in BSplCLib_CacheParams to ensure correct handling of edge cases. - Added checks for floating point precision when determining if the next knot should be used. - Improved code readability by restructuring the return conditions.
4b6e64b to
dd90c4f
Compare
dpasukhi
pushed a commit
to dpasukhi/OCCT
that referenced
this pull request
Nov 17, 2025
…ade-SAS#829 - Enhanced the parameter validation logic in BSplCLib_CacheParams to ensure correct handling of edge cases. - Added checks for floating point precision when determining if the next knot should be used. - Improved code readability by restructuring the return conditions.
dd90c4f to
c7b9234
Compare
…ade-SAS#829 - Enhanced the parameter validation logic in BSplCLib_CacheParams to ensure correct handling of edge cases. - Added checks for floating point precision when determining if the next knot should be used. - Improved code readability by restructuring the return conditions.
c7b9234 to
1a246af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.