Application Framework - Early-return null NamedShape when TNaming_UsedShapes is missing#760
Merged
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom Oct 24, 2025
Merged
Conversation
…aming_UsedShapes is missing Check Acces.Root().FindAttribute(...) result in TNaming_Tool::NamedShape and return an empty Handle if the TNaming_UsedShapes attribute is not found to avoid using an uninitialized map.
There was a problem hiding this comment.
Pull Request Overview
This PR adds a safety check to TNaming_Tool::NamedShape to prevent accessing an uninitialized map when the TNaming_UsedShapes attribute is missing from the document root. The fix returns an empty Handle(TNaming_NamedShape) early if the attribute lookup fails.
Key Changes:
- Added null-check for
TNaming_UsedShapesattribute retrieval - Created comprehensive test suite for
TNaming_Toolclass - Updated CMake configuration to include new test file
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/ApplicationFramework/TKCAF/TNaming/TNaming_NamedShape.cxx | Added early-return check when TNaming_UsedShapes attribute is not found |
| src/ApplicationFramework/TKCAF/GTests/TNaming_Tool_Test.cxx | New comprehensive test suite for TNaming_Tool with 17 test cases |
| src/ApplicationFramework/TKCAF/GTests/FILES.cmake | Registered new test file in CMake build configuration |
VladislavVitalievichRomashko
approved these changes
Oct 23, 2025
AtheneNoctuaPt
approved these changes
Oct 23, 2025
dpasukhi
added a commit
to dpasukhi/OCCT
that referenced
this pull request
Dec 5, 2025
…dShapes is missing (Open-Cascade-SAS#760) Check Acces.Root().FindAttribute(...) result in TNaming_Tool::NamedShape and return an empty Handle if the TNaming_UsedShapes attribute is not found to avoid using an uninitialized map.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check Acces.Root().FindAttribute(...) result in TNaming_Tool::NamedShape and return an empty Handle if the TNaming_UsedShapes attribute is not found to avoid using an uninitialized map.