Modelling - Crash in BRepFilletAPI_MakeChamfer#743
Merged
dpasukhi merged 2 commits intoOpen-Cascade-SAS:IRfrom Oct 16, 2025
Merged
Modelling - Crash in BRepFilletAPI_MakeChamfer#743dpasukhi merged 2 commits intoOpen-Cascade-SAS:IRfrom
dpasukhi merged 2 commits intoOpen-Cascade-SAS:IRfrom
Conversation
Handle a case where a newly created face does not contain a required edge. A minor refactoring of ChFi3d_Builder_2.cxx is performed.
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a crash in BRepFilletAPI_MakeChamfer by handling cases where newly created faces don't contain required edges. The fix includes defensive programming to check for null edge handles and graceful fallback to default behavior when edge lookup fails.
- Refactored helper functions with clearer naming and improved parameter handling
- Added null safety checks to prevent crashes when edge lookup fails in face topology
- Removed debug code and simplified variable declarations for better maintainability
dpasukhi
approved these changes
Oct 16, 2025
dpasukhi
pushed a commit
to dpasukhi/OCCT
that referenced
this pull request
Dec 5, 2025
- Refactored helper functions with clearer naming and improved parameter handling - Added null safety checks to prevent crashes when edge lookup fails in face topology - Removed debug code and simplified variable declarations for better maintainability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle a case where a newly created face does not contain a required edge.
A minor refactoring of ChFi3d_Builder_2.cxx is performed.