Modeling - Crash in BRepOffsetAPI_MakePipeShell#740
Merged
dpasukhi merged 2 commits intoOpen-Cascade-SAS:IRfrom Oct 9, 2025
Merged
Modeling - Crash in BRepOffsetAPI_MakePipeShell#740dpasukhi merged 2 commits intoOpen-Cascade-SAS:IRfrom
dpasukhi merged 2 commits intoOpen-Cascade-SAS:IRfrom
Conversation
Performed a basic refactoring of BRepFill_SectionPlacement::Perform() and fixed a crash.
There was a problem hiding this comment.
Pull Request Overview
This PR performs a refactoring of the BRepFill_SectionPlacement::Perform() method to improve code clarity and fix a crash issue. The refactoring includes modernizing variable naming conventions, simplifying control flow, and enhancing error handling.
Key changes:
- Modernized variable naming to follow OCCT conventions with descriptive prefixes
- Simplified the section geometry processing logic and removed commented-out legacy code
- Improved error handling with clearer exception messages
dpasukhi
pushed a commit
to dpasukhi/OCCT
that referenced
this pull request
Dec 5, 2025
Performed a basic refactoring of BRepFill_SectionPlacement::Perform() and fixed a crash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performed a basic refactoring of BRepFill_SectionPlacement::Perform() and fixed a crash.