Modeling - Segfault on chamfer or fillet approaching ellipse#738
Merged
dpasukhi merged 2 commits intoOpen-Cascade-SAS:IRfrom Oct 7, 2025
Merged
Modeling - Segfault on chamfer or fillet approaching ellipse#738dpasukhi merged 2 commits intoOpen-Cascade-SAS:IRfrom
dpasukhi merged 2 commits intoOpen-Cascade-SAS:IRfrom
Conversation
Fixed nullptr dereference.
dpasukhi
approved these changes
Oct 7, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a segmentation fault that occurs during chamfer or fillet operations when approaching ellipse geometry. The fix addresses a nullptr dereference by adding proper null checking and error handling.
Key Changes
- Added null pointer validation for
C2dint1andC2dint2curve handles - Introduced proper error handling with
Standard_ConstructionErrorexception when p-curves cannot be obtained
dpasukhi
pushed a commit
to dpasukhi/OCCT
that referenced
this pull request
Dec 5, 2025
…scade-SAS#738) Fixed nullptr dereference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed nullptr dereference.