Shape Healing, STP Import - Revolved shape in STEP file is imported inverted#699
Merged
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom Sep 4, 2025
Merged
Conversation
Make the degenerated torus bounded in two values of parameters processed as a regular to insert a seam edge properly.
905e236 to
1c9ec9e
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where revolved shapes in STEP files are imported with inverted orientation by modifying the shape healing logic for degenerated torus surfaces. The fix ensures that when a torus is bounded by two parameter values, it's processed as a regular surface to properly insert seam edges.
Key Changes
- Modified the degenerated torus detection logic to consider the presence of a second wire
- Added a test case to verify the fix for imported STEP files with revolved shapes
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/ModelingAlgorithms/TKShHealing/ShapeFix/ShapeFix_Face.cxx |
Added logic to treat degenerated torus as regular when second wire exists |
tests/bugs/step/gh_bug378 |
Added test case for verifying proper import of revolved STEP shapes |
dpasukhi
pushed a commit
that referenced
this pull request
Sep 6, 2025
…nverted (#699) Make the degenerated torus bounded in two values of parameters processed as a regular to insert a seam edge properly.
dpasukhi
pushed a commit
that referenced
this pull request
Sep 6, 2025
…nverted (#699) Make the degenerated torus bounded in two values of parameters processed as a regular to insert a seam edge properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the degenerated torus bounded in two values of parameters processed as a regular to insert a seam edge properly.