Draw - Fix message color mixing (#685)#685
Merged
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom Aug 24, 2025
Merged
Conversation
Message color from previous message in Unix was mixed.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a message color mixing issue in Unix where console text colors from previous messages would carry over to subsequent output. The fix ensures that text color is properly reset before printing newlines, preventing color bleeding between messages.
Key changes:
- Moved color reset operations to occur before newline output in both
dputscommand and main interpreter - Ensures proper color isolation between console messages
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Draw/TKDraw/Draw/Draw_BasicCommands.cxx |
Reordered color reset to happen before newline in dputs command |
src/Draw/TKDraw/Draw/Draw.cxx |
Separated result output from newline and moved color reset before newline in interpreter |
dpasukhi
pushed a commit
that referenced
this pull request
Sep 6, 2025
Message color from previous message in Unix was mixed.
dpasukhi
pushed a commit
that referenced
this pull request
Sep 6, 2025
Message color from previous message in Unix was mixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Message color from previous message in Unix was mixed.