Coding - Reducing relying on exceptions#676
Merged
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom Aug 16, 2025
Merged
Conversation
Updated PCDM_ReadWriter_1.cxx to avoid exceptions in reading reference counter and version. Updated XSDRAWSTL to avoid null division checks.
There was a problem hiding this comment.
Pull Request Overview
This PR aims to improve error handling by replacing exception-based control flow with explicit condition checks. The changes reduce reliance on exceptions for predictable error conditions, which can improve performance and code clarity.
- Replaced try-catch blocks with explicit validation checks in PCDM_ReadWriter_1.cxx
- Added division-by-zero protection in XSDRAWSTL.cxx using precision-based comparison
- Improved error handling for integer parsing operations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/ApplicationFramework/TKCDF/PCDM/PCDM_ReadWriter_1.cxx | Replaced exception handling with explicit integer validation checks for reading reference counter and document version |
| src/Draw/TKXSDRAWSTL/XSDRAWSTL/XSDRAWSTL.cxx | Added division-by-zero protection using precision comparison instead of exception handling |
| if (aToken.IsIntegerValue()) | ||
| { | ||
| OCC_CATCH_SIGNALS theReferencesCounter = refUserInfo(i).Token(" ", 2).IntegerValue(); | ||
| theReferencesCounter = aToken.IntegerValue(); |
There was a problem hiding this comment.
The variable name 'aToken' follows OCCT naming conventions correctly, but consider using a more descriptive name like 'aCounterToken' to better express its purpose in this context.
| if (aToken.IsIntegerValue()) | ||
| { | ||
| OCC_CATCH_SIGNALS theVersion = refUserInfo(i).Token(" ", 2).IntegerValue(); | ||
| theVersion = aToken.IntegerValue(); |
There was a problem hiding this comment.
Similar to the reference counter case, consider using a more descriptive variable name like 'aVersionToken' instead of the generic 'aToken' for better code clarity.
dpasukhi
added a commit
that referenced
this pull request
Sep 6, 2025
- Replaced try-catch blocks with explicit validation checks in PCDM_ReadWriter_1.cxx - Added division-by-zero protection in XSDRAWSTL.cxx using precision-based comparison - Improved error handling for integer parsing operations
dpasukhi
added a commit
that referenced
this pull request
Sep 6, 2025
- Replaced try-catch blocks with explicit validation checks in PCDM_ReadWriter_1.cxx - Added division-by-zero protection in XSDRAWSTL.cxx using precision-based comparison - Improved error handling for integer parsing operations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated PCDM_ReadWriter_1.cxx to avoid exceptions in reading reference counter and version.
Updated XSDRAWSTL to avoid null division checks.