Modelling - GeomFill_CorrectedFrenet hangs in some cases#630
Merged
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom Jul 21, 2025
Merged
Modelling - GeomFill_CorrectedFrenet hangs in some cases#630dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
Conversation
Added check in GeomFill_CorrectedFrenet::InitInterval() to prevent infinite loop. Added GeomFill_CorrectedFrenet test cases and update FILES.cmake.
dpasukhi
approved these changes
Jul 21, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an infinite loop issue in GeomFill_CorrectedFrenet's InitInterval method by adding a parameter progression check and includes comprehensive test coverage for the fix.
- Added parameter progression check to prevent infinite loops when step size becomes too small
- Improved code formatting and variable naming for better maintainability
- Added comprehensive test suite covering the infinite loop scenario and edge cases
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| GeomFill_CorrectedFrenet.cxx | Fixed infinite loop bug by adding parameter progression check and improved code formatting |
| GeomFill_CorrectedFrenet_Test.cxx | Added comprehensive test cases covering the infinite loop fix and various edge cases |
| FILES.cmake | Added new test file to build configuration |
Comments suppressed due to low confidence (1)
src/ModelingAlgorithms/TKGeomAlgo/GeomFill/GeomFill_CorrectedFrenet.cxx:629
- [nitpick] Variable name 'aParamIndex' is inconsistent with the existing codebase style. Consider using a shorter, more conventional loop variable name like 'i' or 'idx' to match the project's naming conventions.
for (Standard_Integer aParamIndex = 1; aParamIndex <= Length; ++aParamIndex)
dpasukhi
pushed a commit
that referenced
this pull request
Sep 6, 2025
- Added parameter progression check to prevent infinite loops when step size becomes too small - Improved code formatting and variable naming for better maintainability - Added comprehensive test suite covering the infinite loop scenario and edge cases
dpasukhi
pushed a commit
that referenced
this pull request
Sep 6, 2025
- Added parameter progression check to prevent infinite loops when step size becomes too small - Improved code formatting and variable naming for better maintainability - Added comprehensive test suite covering the infinite loop scenario and edge cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added check in GeomFill_CorrectedFrenet::InitInterval() to prevent infinite loop. Added GeomFill_CorrectedFrenet test cases and update FILES.cmake.