Configuration - Fix ARCH for older 32-bit macs#626
Merged
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom Jul 19, 2025
Merged
Configuration - Fix ARCH for older 32-bit macs#626dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
Conversation
Fix architecture check in environment setup scripts to include arm64
There was a problem hiding this comment.
Pull Request Overview
This PR fixes architecture detection in environment setup scripts to properly handle ARM-based architectures and removes redundant ARCH overrides for Darwin systems. The changes ensure that both aarch64 and arm64 architectures are correctly identified as 64-bit systems.
- Updates architecture detection conditions to include aarch64 and arm64 as 64-bit architectures
- Removes redundant ARCH="64" assignment for Darwin systems since it's already handled by the architecture check
- Fixes a syntax error in the existing aarch64 condition
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| adm/templates/env.sh | Updates architecture detection logic and removes Darwin-specific ARCH override |
| adm/templates/env.install.sh.in | Applies same architecture detection fixes and syntax correction |
| # ----- Set path to 3rd party and OCCT libraries ----- | ||
| anArch=`uname -m` | ||
| if [ "$anArch" != "x86_64" ] && [ "$anArch" != "ia64" ] && [ "$anArch" != "aarch64"]; then | ||
| if [ "$anArch" != "x86_64" ] && [ "$anArch" != "ia64" ] && [ "$anArch" != "aarch64" ] && [ "$anArch" != "arm64" ]; then |
There was a problem hiding this comment.
The original line had a syntax error with missing space before the closing bracket in 'aarch64"]; then'. This fix correctly addresses that syntax issue.
dpasukhi
added a commit
that referenced
this pull request
Sep 6, 2025
- Updates architecture detection conditions to include aarch64 and arm64 as 64-bit architectures - Removes redundant ARCH="64" assignment for Darwin systems since it's already handled by the architecture check - Fixes a syntax error in the existing aarch64 condition
dpasukhi
added a commit
that referenced
this pull request
Sep 6, 2025
- Updates architecture detection conditions to include aarch64 and arm64 as 64-bit architectures - Removes redundant ARCH="64" assignment for Darwin systems since it's already handled by the architecture check - Fixes a syntax error in the existing aarch64 condition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix architecture check in environment setup scripts to include arm64