Foundation classes - Leak of WinAPI resources#625
Merged
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom Jul 18, 2025
Merged
Foundation classes - Leak of WinAPI resources#625dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
Conversation
Fix Image_AlienPixMap::Load to use smart pointer for IWICBitmapFlipRotator.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a WinAPI resource leak in the Image_AlienPixMap::Load method by replacing raw pointer management with smart pointer management for IWICBitmapFlipRotator objects. This ensures proper automatic cleanup of COM objects and prevents potential memory leaks.
- Replaces raw IWICBitmapFlipRotator pointer with Image_ComPtr smart pointer wrapper
- Updates pointer access patterns to use smart pointer methods (.ChangePtr() and .get())
- Maintains existing functionality while improving resource management
dpasukhi
approved these changes
Jul 18, 2025
dpasukhi
pushed a commit
that referenced
this pull request
Sep 6, 2025
- Replaces raw IWICBitmapFlipRotator pointer with Image_ComPtr smart pointer wrapper - Updates pointer access patterns to use smart pointer methods (.ChangePtr() and .get()) - Maintains existing functionality while improving resource management
dpasukhi
pushed a commit
that referenced
this pull request
Sep 6, 2025
- Replaces raw IWICBitmapFlipRotator pointer with Image_ComPtr smart pointer wrapper - Updates pointer access patterns to use smart pointer methods (.ChangePtr() and .get()) - Maintains existing functionality while improving resource management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Image_AlienPixMap::Load to use smart pointer for IWICBitmapFlipRotator.