Coding - Small optimization of StepData_StepReaderData#543
Merged
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom May 19, 2025
Merged
Coding - Small optimization of StepData_StepReaderData#543dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
Conversation
Refactor SetEntityNumbers to use reusable memory pool. Update SetRecord to avoid extra map searches.
There was a problem hiding this comment.
Pull Request Overview
Refactors entity number assignment to use a reusable memory pool allocator and streamlines type lookup.
- Introduce
NCollection_IncAllocatorto back maps and sequences inSetEntityNumbers - Simplify
SetRecordby replacing manual lookup with a directthenametypes.Addcall - Remove legacy comment blocks and unused lookup code
Comments suppressed due to low confidence (1)
src/DataExchange/TKDESTEP/StepData/StepData_StepReaderData.cxx:395
- Calling
thenametypes.Addunconditionally appends a new string each time, leading to duplicates. Consider checking iftypealready exists (e.g.,Contains/FindIndex) and only add when absent, to preserve correct indices.
thetypes.ChangeValue(num) = thenametypes.Add(TCollection_AsciiString(type));
dpasukhi
added a commit
to dpasukhi/OCCT
that referenced
this pull request
May 19, 2025
…AS#543 Refactor SetEntityNumbers to use reusable memory pool. Update SetRecord to avoid extra map searches.
dpasukhi
added a commit
to dpasukhi/OCCT
that referenced
this pull request
May 20, 2025
…AS#543 Refactor SetEntityNumbers to use reusable memory pool. Update SetRecord to avoid extra map searches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor SetEntityNumbers to use reusable memory pool.
Update SetRecord to avoid extra map searches.