Testing - Add a new compilation on Clang without PCH#540
Merged
dpasukhi merged 6 commits intoOpen-Cascade-SAS:IRfrom May 17, 2025
Merged
Testing - Add a new compilation on Clang without PCH#540dpasukhi merged 6 commits intoOpen-Cascade-SAS:IRfrom
dpasukhi merged 6 commits intoOpen-Cascade-SAS:IRfrom
Conversation
Updated a main workflow to validate the header and more precise warnings. No PCH helps to validate missed headers.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new job to build on Clang without precompiled headers to help validate header inclusion and warn about missing headers.
- Added the "prepare-and-build-linux-clang-no-pch" job in the workflow file.
- Updated the build-occt action to accept a new input "build-use-pch" and use it in CMake configuration.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/build-and-test-multiplatform.yml | Added a new job to build using Clang without precompiled headers |
| .github/actions/build-occt/action.yml | Introduced the "build-use-pch" input and updated CMake commands to use it |
…d update workflow to use default value
…tion sections for non-macOS platforms
…ndling in build workflows
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new build configuration for Clang without using precompiled headers in order to validate header dependencies and enable more precise warning detection.
- Introduces a new workflow job "Prepare and Build on Ubuntu with Clang (No PCH)" in the multiplatform CI.
- Modifies the build action configuration to drive PCH usage and optimization profile via inputs.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/build-and-test-multiplatform.yml | Adds a new CI job for building with Clang without PCH |
| .github/actions/build-occt/action.yml | Updates action inputs and adjusts cmake commands to dynamically use PCH and optimization profile |
Files not reviewed (1)
- adm/cmake/occt_defs_flags.cmake: Language not supported
Comments suppressed due to low confidence (1)
.github/actions/build-occt/action.yml:111
- Ensure that splitting the additional-cmake-flags onto a separate line preserves the intended concatenation of flags. Verify that the command-line construction behaves as before after this change.
-D INSTALL_GTEST=ON `
mzernova
approved these changes
May 17, 2025
…ult to Debug in build-and-test-multiplatform.yml
…(No PCH) to use macOS 15
dpasukhi
added a commit
to dpasukhi/OCCT
that referenced
this pull request
May 19, 2025
…#540 Fixed PCH issue for mac os
dpasukhi
added a commit
to dpasukhi/OCCT
that referenced
this pull request
May 20, 2025
…#540 Fixed PCH issue for mac os
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated a main workflow to validate the header and more precise warnings.
No PCH helps to validate missed headers.