Modeling Algorithms - XCAFDoc_Editor::RescaleGeometry does not rescale translation of roots reference#529
Merged
dpasukhi merged 2 commits intoOpen-Cascade-SAS:IRfrom May 14, 2025
Conversation
…e translation of roots references Add processing of roots, which are transformed references of parts/assemblies.
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the handling of root nodes in the assembly graph by incorporating transformed references during geometry rescaling.
- Introduces new variables to manage node IDs for both original and referenced shapes.
- Changes component checking from IsComponent to IsReference to correctly classify transformed parts/assemblies.
Files not reviewed (1)
- tests/bugs/xde/ar10850: Language not supported
Comments suppressed due to low confidence (2)
src/DataExchange/TKXCAF/XCAFDoc/XCAFDoc_AssemblyGraph.cxx:143
- [nitpick] Consider renaming 'anIdToProceed' to a more descriptive identifier (e.g., 'childNodeId') for improved clarity.
anIdToProceed = addNode(anOriginal, aRootId);
src/DataExchange/TKXCAF/XCAFDoc/XCAFDoc_AssemblyGraph.cxx:153
- Verify that passing 'anIdToProceed' instead of 'aRootId' to addComponents aligns with the desired rescaling behavior for transformed references.
addComponents(anOriginal, anIdToProceed);
dpasukhi
approved these changes
May 14, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue with the rescaling of translations for roots references by updating how node IDs are assigned and how shape types are determined.
- Introduces separate node IDs for the root and its corresponding child node using aRootId and anIdToProceed.
- Updates the condition to use IsReference instead of IsComponent for proper type detection.
Files not reviewed (1)
- tests/bugs/xde/ar10850: Language not supported
Comments suppressed due to low confidence (2)
src/DataExchange/TKXCAF/XCAFDoc/XCAFDoc_AssemblyGraph.cxx:131
- [nitpick] The variable name 'anIdToProceed' is ambiguous; consider renaming it to a more descriptive name (e.g., 'childNodeId') for improved readability.
Standard_Integer aRootId, anIdToProceed;
src/DataExchange/TKXCAF/XCAFDoc/XCAFDoc_AssemblyGraph.cxx:222
- Changing the condition from IsComponent to IsReference alters how shape labels are classified; ensure that this change aligns with the overall API design and that related documentation is updated accordingly.
else if (myShapeTool->IsReference(theLabel))
Comment on lines
+153
to
154
| addComponents(anOriginal, anIdToProceed); | ||
| } |
There was a problem hiding this comment.
Updating the call to addComponents with 'anIdToProceed' instead of 'aRootId' changes the node context being processed; please add a clarifying inline comment or documentation to explain this decision.
Suggested change
| addComponents(anOriginal, anIdToProceed); | |
| } | |
| { | |
| // Use 'anIdToProceed' instead of 'aRootId' to ensure that the context | |
| // being processed reflects the correct parent-child relationship in the graph. | |
| addComponents(anOriginal, anIdToProceed); | |
| } |
dpasukhi
pushed a commit
to dpasukhi/OCCT
that referenced
this pull request
May 19, 2025
…e translation of roots reference (Open-Cascade-SAS#529) Add processing of roots, which are transformed references of parts/assemblies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add processing of roots, which are transformed references of parts/assemblies.