Modeling - General Fuse (BOPAlgo_PaveFiller) optimization#514
Merged
dpasukhi merged 2 commits intoOpen-Cascade-SAS:IRfrom May 15, 2025
Merged
Modeling - General Fuse (BOPAlgo_PaveFiller) optimization#514dpasukhi merged 2 commits intoOpen-Cascade-SAS:IRfrom
dpasukhi merged 2 commits intoOpen-Cascade-SAS:IRfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request optimizes the general fuse functionality in the BOPAlgo_PaveFiller module by refactoring logic for face-face processing and improving index retrieval in data structures. Key changes include:
- Adding a null check for the triangulation in BRep_Tool::IsClosed.
- Simplifying index lookup logic in BOPDS_DS.
- Introducing helper functions (IsPlaneFF and IsClosedFF) and updating iteration loops in BOPAlgo_PaveFiller_6 for improved clarity and robustness.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/ModelingData/TKBRep/BRep/BRep_Tool.cxx | Adds a null check for triangulation in IsClosed. |
| src/ModelingAlgorithms/TKBO/BOPDS/BOPDS_DS.cxx | Refactors index lookup using a streamlined Find call. |
| src/ModelingAlgorithms/TKBO/BOPAlgo/BOPAlgo_PaveFiller_6.cxx | Introduces helper functions and updates loops for improved face-edge iteration. |
Comments suppressed due to low confidence (1)
src/ModelingAlgorithms/TKBO/BOPAlgo/BOPAlgo_PaveFiller_6.cxx:425
- [nitpick] Consider renaming the loop iterators (for example, 'aItW1' and 'aItE1') to more descriptive names (e.g., 'faceIterator' and 'edgeIterator') to improve code readability.
for (TopoDS_Iterator aItE1(aItW1.Value()); !anIsFound && aItE1.More(); aItE1.Next())
dpasukhi
approved these changes
May 15, 2025
dpasukhi
pushed a commit
to dpasukhi/OCCT
that referenced
this pull request
May 19, 2025
…e-SAS#514 Adding a null check for the triangulation in BRep_Tool::IsClosed. Simplifying index lookup logic in BOPDS_DS. Introducing helper functions (IsPlaneFF and IsClosedFF) and updating iteration loops in BOPAlgo_PaveFiller_6 for improved clarity and robustness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a null check for the triangulation in BRep_Tool::IsClosed.
Simplifying index lookup logic in BOPDS_DS.
Introducing helper functions (IsPlaneFF and IsClosedFF) and updating iteration loops in BOPAlgo_PaveFiller_6 for improved clarity and robustness.