Skip to content

Conversation

@alamb
Copy link

@alamb alamb commented Dec 30, 2024

The submodule wasn't working for me for some reason. I ran these commands locally to create this PR

(venv) andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion2$ git rm datafusion-testing
rm 'datafusion-testing'
(venv) andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion2$ git submodule add --force https://github.com/apache/datafusion-testing.git
Reactivating local git directory for submodule 'datafusion-testing'
(venv) andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion2$ git add datafusion-testing/
(venv) andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion2$ git commit -a -m 'Readd submodule'
[alamb/fix_datafusion-testing 5230c8bfc] Readd submodule
 1 file changed, 1 insertion(+), 1 deletion(-)
 mode change 100755 => 160000 datafusion-testing

I don't know what mode change 100755 => 160000 datafusion-testing means, but it seems like the github UI suggests git can now recognize this directory as a submodule:
Screenshot 2024-12-30 at 6 22 17 AM

@Omega359 Omega359 merged commit de58d35 into Omega359:sqllogictest_with_sqlite Dec 30, 2024
26 checks passed
@alamb alamb deleted the alamb/fix_datafusion-testing branch January 1, 2025 14:38
Omega359 pushed a commit that referenced this pull request Feb 10, 2025
…4544)

* add mut annotation

* fix rust examples

* fix rust examples

* update

* fix first doctest

* fix first doctest

* fix more doctest

* fix more doctest

* fix more doctest

* adopt rustdoc syntax

* adopt rustdoc syntax

* adopt rustdoc syntax

* fix more doctest

* add missing imports

* final udtf

* reenable

* remove dep

* run prettier

* api-health

* update doc

* update doc

* temp fix

* fix doc

* fix async schema provider

* fix async schema provider

* fix doc

* fix doc

* reorder

* refactor

* s

* finish

* minor update

* add missing docs

* add deps (#3)

* fix doctest

* update doc

* fix doctest

* fix doctest

* tweak showkeys

* fix doctest

* fix doctest

* fix doctest

* fix doctest

* update to use user_doc

* add rustdoc preprocessing

* fix dir

* revert to original doc

* add allocator

* mark type

* update

* fix doctest

* add doctest

* add doctest

* fix doctest

* fix doctest

* fix doctest

* fix doctest

* fix doctest

* fix doctest

* fix doctest

* fix doctest

* fix doctest

* prettier format

* revert change to datafusion-testing

* add apache header

* install cmake in setup-builder for ci workflow dependency

* taplo + fix snmalloc

* Update function docs

* preprocess user-guide

* Render examples as sql

* fix intro

* fix docs via script

---------

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
alamb pushed a commit that referenced this pull request Aug 4, 2025
… default null ordering (apache#16963)

* Allow to set up the default null ordering (#3)

* add default_null_ordering config

* add test for different config

* Update datafusion/sql/src/planner.rs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* update doc

* fix sqllogictest

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* rename config and fix test

* update doc

* fix default

* fix doc

* fix sqllogictests

* address comments

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants