fix(desktop): restore desktop-uninstall.cjs dropped by #152 sync (app crash on launch)#156
Merged
Merged
Conversation
…eam sync electron/main.cjs:42 requires './desktop-uninstall.cjs' (modeRemovesUserData, resolveRemovableAppPath, shouldRemoveAppBundle, uninstallArgsForMode), and package.json's test:desktop:platforms references desktop-uninstall.test.cjs — but both files were dropped during the #152 sync merge while their references survived. The packaged app crashed on launch: "Cannot find module './desktop-uninstall.cjs'" at main.cjs:42. Restored both verbatim from upstream/main (the uninstall feature, NousResearch#40355). node --test: 19/19 pass; main.cjs resolves past the require. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
🔎 Lint report:
|
OmarB97
pushed a commit
that referenced
this pull request
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Critical: the packaged app crashes on launch.
electron/main.cjs:42requires./desktop-uninstall.cjs(andpackage.json'stest:desktop:platformsreferencesdesktop-uninstall.test.cjs), but both files were dropped during the #152 upstream-sync merge while their references survived — a split-brain casualty. Result:Uncaught Exception: Error: Cannot find module './desktop-uninstall.cjs'atmain.cjs:42, app won't start.Restored both verbatim from
upstream/main(the uninstall-Chat-GUI feature, NousResearch#40355).node --test electron/desktop-uninstall.test.cjs→ 19/19 pass;main.cjsresolves past the require. Fork-only fix (upstream already has these files).