Skip to content

Port: Fix searching for tx hash in block for ArbitrumLegacyTx (#4096)#4097

Merged
joshuacolvin0 merged 1 commit into
v3.9.x-releasefrom
backport-fix-classic-tx-by-hash
Dec 1, 2025
Merged

Port: Fix searching for tx hash in block for ArbitrumLegacyTx (#4096)#4097
joshuacolvin0 merged 1 commit into
v3.9.x-releasefrom
backport-fix-classic-tx-by-hash

Conversation

@magicxyyz

@magicxyyz magicxyyz commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

Resolves NIT-4170

Backports #4096

Pulls in: OffchainLabs/go-ethereum#591

@magicxyyz magicxyyz changed the title backport: pull in geth fix for tx by hash for classic txes backport: Fix searching for tx hash in block for ArbitrumLegacyTx Dec 1, 2025
@magicxyyz magicxyyz requested a review from Copilot December 1, 2025 18:41
Copilot AI reviewed Dec 1, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR backports a fix for searching transaction hashes in blocks specifically for ArbitrumLegacyTx transaction types. The change updates the go-ethereum submodule to incorporate the necessary fix from upstream.

Key Changes:

  • Updates go-ethereum submodule pointer to include the ArbitrumLegacyTx transaction hash search fix

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@magicxyyz magicxyyz marked this pull request as ready for review December 1, 2025 18:53
KolbyML
KolbyML approved these changes Dec 1, 2025
View reviewed changes

@KolbyML KolbyML left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: looks good

@KolbyML KolbyML assigned joshuacolvin0 and unassigned KolbyML Dec 1, 2025
@github-actions

github-actions Bot commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

❌ 6 Tests Failed:

Tests completed Failed Passed Skipped
2169 6 2163 0
View the top 3 failed tests by shortest run time 
TestDataStreaming_PositiveScenario/Many_senders,_long_messages
Stack Traces | 0.060s run time 
... [CONTENT TRUNCATED: Keeping last 20 lines]
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic.func1()
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:230 +0x14f
        created by github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic in goroutine 296
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:223 +0x85
        
    protocol_test.go:230: �[31;1m [] too much time has elapsed since request was signed �[0;0m
INFO [12-01|18:38:03.045] rpc response                             method=datastreaming_start logId=1  err="too much time has elapsed since request was signed" result={} attempt=0 args="[\"0x692de08a\", \"0x2b\", \"0xd9\", \"0x23a0\", \"0xa\", \"0x5233b77fc2dae5ad9610dd4bbd50330d9e1b869115adccc46c7bed5a30d118a111a3046630c7c069b1167a04b8c1dd58a65468b1bb9c8c3afc9a9ec819c0778c00\"]" errorData=null
    protocol_test.go:230: goroutine 310 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.4/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x1568f50, 0xc0006a28c0}, {0x154f9c0, 0xc000d08ba0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic.func1()
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:230 +0x14f
        created by github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic in goroutine 296
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:223 +0x85
        
    protocol_test.go:230: �[31;1m [] too much time has elapsed since request was signed �[0;0m
--- FAIL: TestDataStreaming_PositiveScenario/Many_senders,_long_messages (0.06s)

TestDataStreaming_PositiveScenario
Stack Traces | 0.080s run time 
=== RUN   TestDataStreaming_PositiveScenario
--- FAIL: TestDataStreaming_PositiveScenario (0.08s)

TestValidationInputsAtWithWasmTarget
Stack Traces | 2.670s run time 
... [CONTENT TRUNCATED: Keeping last 20 lines]
        github.com/offchainlabs/nitro/system_tests.TestValidationInputsAtWithWasmTarget(0xc024564e00)
        	/home/runner/work/nitro/nitro/system_tests/validation_inputs_at_test.go:70 +0x970
        testing.tRunner(0xc024564e00, 0x3d09600)
        	/opt/hostedtoolcache/go/1.25.4/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.4/x64/src/testing/testing.go:1997 +0x465
        
    validation_inputs_at_test.go:70: �[31;1m [] failed calculating position for validation: batch not found on L1 yet �[0;0m
�[90mCall trace:�[0;0m
�[90mi	depth	opcode	stack�[0;0m
�[90m0	1	SLOAD	[0x15fed0451499512d95f3ec5a41c878b9de55f21878b5b4e190d4667ec709b400]�[0;0m
�[90m1	1	SLOAD	[0x3c79da47f96b0f39664f73c0a1f350580be90742947dddfa21ba64d578dfe600]�[0;0m
�[90m2	1	CALLDATACOPY	[0xfc 0x0 0x0]�[0;0m
�[90m3	1	LOG4	[0x6b2dab86e7f292b4e529c244fdda3144e9d3407f7aff475eccbe6bd1eed97b0b 0x59a261fbf687667c5796a3925b87211a32fed0052fd8215e075d8e95f316f3aa 0x997b0004b2d58ed31c99ca6a7184337d88c3353e208d9161334b3b6afaf400a 0xafb7cee0b72cb44efa06301423b006ca02c3c901bafc8d1c0f23660f2dbe0abe 0x7b 0x0]�[0;0m
�[90m4	1	STOP	[]�[0;0m
ERROR[12-01|18:46:16.286] Dangling trie nodes after full cleanup
ERROR[12-01|18:46:16.315] Dangling trie nodes after full cleanup
INFO [12-01|18:46:16.333] HTTP server stopped                      endpoint=127.0.0.1:37131
TRACE[12-01|18:46:16.333] P2P networking is spinning down
--- FAIL: TestValidationInputsAtWithWasmTarget (2.67s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@joshuacolvin0 joshuacolvin0 mentioned this pull request Dec 1, 2025
Merged
@joshuacolvin0 joshuacolvin0 changed the title backport: Fix searching for tx hash in block for ArbitrumLegacyTx Port: Fix searching for tx hash in block for ArbitrumLegacyTx Dec 1, 2025
@joshuacolvin0 joshuacolvin0 merged commit f9ac116 into v3.9.x-release Dec 1, 2025
18 checks passed
@joshuacolvin0 joshuacolvin0 deleted the backport-fix-classic-tx-by-hash branch December 1, 2025 20:28
@joshuacolvin0 joshuacolvin0 changed the title Port: Fix searching for tx hash in block for ArbitrumLegacyTx Port: Fix searching for tx hash in block for ArbitrumLegacyTx (#4096) Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@KolbyML KolbyML KolbyML approved these changes

@joshuacolvin0 joshuacolvin0 Awaiting requested review from joshuacolvin0

Assignees

@joshuacolvin0 joshuacolvin0

Labels

design-approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@magicxyyz @KolbyML @joshuacolvin0