Skip to content

Fix searching for tx hash in block for ArbitrumLegacyTx#4096

Merged
joshuacolvin0 merged 2 commits into
masterfrom
fix-classic-tx-by-hash
Dec 2, 2025
Merged

Fix searching for tx hash in block for ArbitrumLegacyTx#4096
joshuacolvin0 merged 2 commits into
masterfrom
fix-classic-tx-by-hash

Conversation

@magicxyyz

@magicxyyz magicxyyz commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

@magicxyyz magicxyyz force-pushed the fix-classic-tx-by-hash branch from e1cb0bb to 609df91 Compare December 1, 2025 16:29
@github-actions

github-actions Bot commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
2174 3 2171 0
View the top 3 failed tests by shortest run time
TestValidationInputsAtWithWasmTarget
Stack Traces | 2.570s run time
=== RUN   TestValidationInputsAtWithWasmTarget
=== PAUSE TestValidationInputsAtWithWasmTarget
=== CONT  TestValidationInputsAtWithWasmTarget
    validation_inputs_at_test.go:70: goroutine 1495217 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.4/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40e50b0, 0xc0e0697340}, {0x40a24c0, 0xc017a3afc0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc0e0697340, {0x40a24c0, 0xc017a3afc0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1813 +0x5d
        github.com/offchainlabs/nitro/system_tests.TestValidationInputsAtWithWasmTarget(0xc0e0697340)
        	/home/runner/work/nitro/nitro/system_tests/validation_inputs_at_test.go:70 +0x970
        testing.tRunner(0xc0e0697340, 0x3d27d20)
        	/opt/hostedtoolcache/go/1.25.4/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.4/x64/src/testing/testing.go:1997 +0x465
        
    validation_inputs_at_test.go:70: �[31;1m [] failed calculating position for validation: batch not found on L1 yet �[0;0m
--- FAIL: TestValidationInputsAtWithWasmTarget (2.57s)
TestVersion40
Stack Traces | 5.220s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
�[38;5;48;1myay!! we validated block 15 in 64.80ms�[0;0m
�[38;5;48;1myay!! we validated block 16 in 59.53ms�[0;0m
    precompile_inclusion_test.go:94: goroutine 453861 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.4/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40e50b0, 0xc061486fc0}, {0x40a2940, 0xc08a0c8ae0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc061486fc0, {0x40a2940, 0xc08a0c8ae0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1813 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc061486fc0, 0x28, {0xc077247df8, 0x5, 0x39?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:94 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion40(0xc061486fc0?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:71 +0x64b
        testing.tRunner(0xc061486fc0, 0x3d27d40)
        	/opt/hostedtoolcache/go/1.25.4/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.4/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:94: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestVersion40 (5.22s)
TestBatchPosterActuallyPostsBlobsToL1
Stack Traces | 23.290s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
TRACE[12-01|16:42:26.654] Handled RPC response                     reqid=9049  duration="2.465µs"
TRACE[12-01|16:42:26.654] Handled RPC response                     reqid=22323 duration="1.613µs"
TRACE[12-01|16:42:26.654] Handled RPC response                     reqid=1090  duration="1.723µs"
TRACE[12-01|16:42:26.654] Handled RPC response                     reqid=22324 duration="1.954µs"
DEBUG[12-01|16:42:26.654] Executing EVM call finished              runtime="336.942µs"
DEBUG[12-01|16:42:26.654] Served eth_call                          reqid=1452  duration="459.992µs"
TRACE[12-01|16:42:26.654] Handled RPC response                     reqid=22    duration="2.614µs"
DEBUG[12-01|16:42:26.654] Pushed sync data from consensus to execution synced=true  maxMessageCount=4   updatedAt=2025-12-01T16:42:26+0000 hasProgressMap=false
TRACE[12-01|16:42:26.653] Handled RPC response                     reqid=4023  duration="2.354µs"
DEBUG[12-01|16:42:26.654] Executing EVM call finished              runtime="322.274µs"
DEBUG[12-01|16:42:26.654] Executing EVM call finished              runtime="230.141µs"
DEBUG[12-01|16:42:26.654] Served eth_getBlockByNumber              reqid=6215  duration="174.988µs"
DEBUG[12-01|16:42:26.654] Served eth_call                          reqid=22326 duration="278.562µs"
DEBUG[12-01|16:42:26.654] Pushed sync data from consensus to execution synced=true  maxMessageCount=8   updatedAt=2025-12-01T16:42:26+0000 hasProgressMap=false
DEBUG[12-01|16:42:26.654] Executing EVM call finished              runtime="364.373µs"
DEBUG[12-01|16:42:26.654] Served eth_getBlockByNumber              reqid=7149  duration="129.973µs"
DEBUG[12-01|16:42:26.654] Served eth_getBlockByNumber              reqid=1616  duration="119.044µs"
TRACE[12-01|16:42:26.654] Handled RPC response                     reqid=6215  duration="1.723µs"
--- FAIL: TestBatchPosterActuallyPostsBlobsToL1 (23.29s)
TRACE[12-01|16:42:26.654] Handled RPC response                     reqid=1452  duration="1.824µs"

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@magicxyyz magicxyyz requested a review from KolbyML December 1, 2025 16:37
@magicxyyz magicxyyz marked this pull request as ready for review December 1, 2025 17:57

@KolbyML KolbyML left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: looks good

@joshuacolvin0 joshuacolvin0 changed the title pull in geth fix for tx by hash for classic txes Fix searching for tx hash in block for ArbitrumLegacyTx Dec 1, 2025
@KolbyML

KolbyML commented Dec 1, 2025

Copy link
Copy Markdown
Member

@joshuacolvin0 this PR needs a design approval check

@joshuacolvin0 joshuacolvin0 added this pull request to the merge queue Dec 2, 2025
Merged via the queue into master with commit 9dd4435 Dec 2, 2025
27 checks passed
@joshuacolvin0 joshuacolvin0 deleted the fix-classic-tx-by-hash branch December 2, 2025 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants