[DRAFT] [Backport 9.8] Yet another MEGA (Make ETRS89 Great Again) fix!#4739
Draft
[DRAFT] [Backport 9.8] Yet another MEGA (Make ETRS89 Great Again) fix!#4739
Conversation
I've been made aware that ETRS89 to MGI was semi broken since the EPSG update that added a ETRS89-AUT [2002] datum and migrated the 'MGI to ETRS89 (8)' transformation using the last released grid AT_GIS_GRID_2021_09_28 to be 'MGI to ETRS89-AUT [2002]' and thus leaving user with the older transformation 'MGI to ETRS89 (5)'. This is just one manifestation of a problem that can be seen with ETRS89 in the Netherlands, Romania, etc. Until EPSG perhaps figures out a plan to restore cleanly backward compatibility (they have been made aware of those issues), I've devised the following s/hack/strategy that seems to work (TM): When looking for ETRS89 (EPSG:4258 the datum ensemble) to XXXX transformations, also query the ``alias_name`` table for old names of transformations that start with 'ETRS89 to XXXX' or 'XXXX to ETRS89', and are aliases to 'ETRS89-YYY to XXXX[something]' or 'XXXX to ETRS89-YYY[something]' newly named transformation. And then consider those 'migrated' transformations to be also used for plain ETRS89, because they used to be used for it! No new test cases, but actually reverting to old reference values before commit 047e5db (update to EPSG 12.033) that changed them.
Member
Author
|
will need rework as steps on the toes of #4741. Actually if we pursue this PR, the best way forward would likely be to revert PR 4741 which is a (complex) revert |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #4736