Fix/simple accordion tabindex#2271
Merged
boxadesign merged 3 commits intoreworked-testsfrom Jun 22, 2022
Merged
Conversation
Merged
kruncher
reviewed
Jun 21, 2022
| this.collapsibleHeader.setAttribute('aria-controls', collapsibleId); | ||
|
|
||
| if (!this.isAccordion) { | ||
| if (!this.isAccordion || (this.isAccordion && this.isSimpleAccordion)) { |
Contributor
There was a problem hiding this comment.
This could be simplified to:
if (!this.isAccordion || this.isSimpleAccordion) {
Contributor
There was a problem hiding this comment.
this.isAccordion has to be true if it wasn't false.
kruncher
approved these changes
Jun 21, 2022
jrbarnes9
approved these changes
Jun 21, 2022
boxadesign
added a commit
that referenced
this pull request
Feb 17, 2023
Fix/simple accordion tabindex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Fixes #2147
Also adds tests in the collapsible script tests to cover the scenario when the collapsible is and accordion and when the collapsible is an accordion and the simple variant.
How to review
Review code and check tests