Closed
Conversation
Ticket: 4112 Move it away from http2 to generic core crate. And use it for DCERPC (and SMB) And remove the C version. Main change in API is the free function is not free itself, but a rust wrapper around unbox.
Ticket: 4112
Ticket: 4112
Ticket: 4112
This was referenced Apr 25, 2022
Contributor
Author
|
Needs OISF/suricata-verify#809 for CI to pass... |
Contributor
Author
|
Replaced by #7305 |
zemeteri
added a commit
to zemeteri/suricata
that referenced
this pull request
Oct 4, 2024
Commit changes are made to avoid possible memory leaks. If the parser is initialized before configuration file checking, there was no deinit call before function return. Do check config file existance and type before YAML parser initialization, so we don't need to deinit parser before exiting the function. Bug: OISF#7302
zemeteri
added a commit
to zemeteri/suricata
that referenced
this pull request
Oct 8, 2024
Commit changes are made to avoid possible memory leaks. If the parser is initialized before configuration file checking, there was no deinit call before function return. Do check config file existance and type before YAML parser initialization, so we don't need to deinit parser before exiting the function. Bug: OISF#7302
zemeteri
added a commit
to zemeteri/suricata
that referenced
this pull request
Oct 10, 2024
Commit changes are made to avoid possible memory leaks. If the parser is initialized before configuration file checking, there was no deinit call before function return. Do check config file existance and type before YAML parser initialization, so we don't need to deinit parser before exiting the function. Bug: OISF#7302
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Oct 12, 2024
Commit changes are made to avoid possible memory leaks. If the parser is initialized before configuration file checking, there was no deinit call before function return. Do check config file existance and type before YAML parser initialization, so we don't need to deinit parser before exiting the function. Bug: OISF#7302
jufajardini
pushed a commit
to jufajardini/suricata
that referenced
this pull request
Oct 21, 2024
Commit changes are made to avoid possible memory leaks. If the parser is initialized before configuration file checking, there was no deinit call before function return. Do check config file existance and type before YAML parser initialization, so we don't need to deinit parser before exiting the function. Bug: OISF#7302 (cherry picked from commit 87e6e93)
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Oct 22, 2024
Commit changes are made to avoid possible memory leaks. If the parser is initialized before configuration file checking, there was no deinit call before function return. Do check config file existance and type before YAML parser initialization, so we don't need to deinit parser before exiting the function. Bug: OISF#7302 (cherry picked from commit 87e6e93)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4112
Describe changes:
DetectUintstructure fordsizeanddcerpc,ttl,tcpmss,filesize(and template2)Replaces #7170 with rebase to get better CI
Further work, but this PR can already be merged:
set_uintin loggers to see if we can easily a new keywords