Closed
Conversation
If we missed the tree connect we can't know for sure if we're reading from a (DCERPC) PIPE or not. In this case probe the data to see if it looks like DCERPC. If the detection succeeds, use a special 'suricata::dcerpc' service in the TX. Simplify handling of DCERPC records that cross records Update logging for the response only TXs.
Remove 'experimental' label for Rust, and enable it by default if rustc and cargo (and libjansson) are available. Add rustc and cargo versions to the build-info.
Don't allocate an output buffer for each call. These buffers would have the exact same size every time.
Add simple helper funcs for option-less loggers
Add support for community flow id, meant to give a records a predictable flow id that can be used to match records to output of other tools. Takes a 'seed' that needs to be same across sensors and tools to make the id less predictable.
Member
Author
|
@regit fixed the ICMP issue |
Member
Author
|
Replaced by #3506 |
amirabell
pushed a commit
to amirabell/suricata
that referenced
this pull request
Jun 16, 2020
This changeset fixes a bug on the computation of the buffer lenght for raw http headers. The bug is due to a mismatch on the data type of the length (uint8_t vs uint32_t) and it was causing signature misses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/2638
Describe changes:
PRScript output (if applicable):