Skip to content

ported schema changes to the Leartes evidence webapi#40

Merged
chrisknoll merged 22 commits intoOHDSI:masterfrom
rkboyce:master
Aug 6, 2015
Merged

ported schema changes to the Leartes evidence webapi#40
chrisknoll merged 22 commits intoOHDSI:masterfrom
rkboyce:master

Conversation

@rkboyce
Copy link
Contributor

@rkboyce rkboyce commented May 14, 2015

The Laertes evidence component is now current with the table schema as present in the OHDSI schema. Flyway was used for migration. All my testing indicates that the code runs fine and is ready merging upstream.

@anthonysena
Copy link
Collaborator

Rich, we were taking a look at this branch and came across a few flyway scripts that need adjustment for SQL Server.

The following script needs to be renamed to include two underscores: V1.0.0.6.1__schema-create_laertes.sql

Then in V1.0.0.6.2__schema-create_laertes.sql the following needs a syntax change:

ALTER TABLE LAERTES_SUMMARY DROP COLUMN eb05;
ALTER TABLE LAERTES_SUMMARY DROP COLUMN ebgm;

I made the adjustments to a clone of your code locally and once I did that I was able to verify that the evidence service is in good working order. If you could make these adjustments, we'll get this merged into the main branch. Thanks!

@rkboyce
Copy link
Contributor Author

rkboyce commented Jul 29, 2015

Ok. I implemented those changes and synced my fork with OHDSI. Please let me know if there is anything further I need to do. Thanks! -R

@rkboyce
Copy link
Contributor Author

rkboyce commented Aug 4, 2015

Sorry about that guys. I think it is fixed now. Would you please recheck? thanks

@anthonysena
Copy link
Collaborator

Looks like the old file is still hanging around in the source tree which is causing the flyway script deployment to fail in my testing. Can you please remove this file: V1.0.0.6.1_schema-create__laertes.sql and then we should be set. Thanks!

@chrisknoll
Copy link
Collaborator

@rkboyce , you can delete the old file directly in github UI. Just navigate to the folder, click the file, and then click the trashcan icon on the top right to delete the file. I think it will automatically commit the delete (you may need to provide a message). I'm not sure why it didn't identify the new file as a rename unless you made a copy of the file and gave it a different name.

@anthonysena
Copy link
Collaborator

@chrisknoll let's merge in Rich's changes and delete the flyway script that is no longer needed. I've tested and all of the LAERTES services are working well.

chrisknoll added a commit that referenced this pull request Aug 6, 2015
ported schema changes to the Leartes evidence webapi
@chrisknoll chrisknoll merged commit 39b5917 into OHDSI:master Aug 6, 2015
TomWhite-MedStar added a commit to TomWhite-MedStar/WebAPI that referenced this pull request Apr 25, 2023
alex-odysseus pushed a commit that referenced this pull request Sep 6, 2024
Fixed NullPointerException during saving of a cohort characterization with missing design
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants