Skip to content

OpenID Connect custom parameters#2254

Merged
chrisknoll merged 2 commits intoOHDSI:masterfrom
RowanErasmus:master
May 18, 2023
Merged

OpenID Connect custom parameters#2254
chrisknoll merged 2 commits intoOHDSI:masterfrom
RowanErasmus:master

Conversation

@RowanErasmus
Copy link
Collaborator

Hi!

I would like to be able to pass the 'domain_hint' parameter with oidc authorization for 'a slightly more streamlined user experience' (https://learn.microsoft.com/en-us/azure/active-directory/develop/v2-oauth2-auth-code-flow) with Azure Active Directory.

When using it it would look something like this "security.oid.customParams={"domain_hint":"your.org"}"

Would be happy to hear what you think :-)

@chrisknoll
Copy link
Collaborator

We should add documentation to security configuration to indicate the new OpenID config param customParams that takes a comma delim tuple key1:value1,key2:value2.

For Azure AD, the use case is domain_hint:your_org.

@chrisknoll chrisknoll merged commit 456c178 into OHDSI:master May 18, 2023
@chrisknoll
Copy link
Collaborator

chrisknoll commented May 31, 2023

We just received a report on the forums indicating a 'circular placeholder reference 'security.oid.customPrams in property definitions', and I'm wondering if there's some sort of cicular reference introduced in this PR. This was when the app is run in a docker environment (IE: broadsea) and i'm not sure if there's some issue there. I didn't see this error when I reviewed this PR, however, I also didn't run it under broadsea.

@RowanErasmus , any thoughts?

Reference: https://forums.ohdsi.org/t/broadsea-installation-using-bigquery/18542/24

@RowanErasmus
Copy link
Collaborator Author

Hi @chrisknoll this issue appeared during developing this feature once and then disappeared again, I'm going to take a closer look tomorrow. In the meanwhile you may want to revert the merge...

@RowanErasmus
Copy link
Collaborator Author

RowanErasmus commented Jun 1, 2023

I'm guessing it has to do with caching going belly up in the docker build as this error should not occur because the value is defined in the pom.xml. I've responded in the forum

pieterlukasse pushed a commit to pieterlukasse/WebAPI that referenced this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants