Merged
Conversation
# Conflicts: # js/pages/incidence-rates/ir-manager.js
chrisknoll
approved these changes
Aug 12, 2021
Collaborator
chrisknoll
left a comment
There was a problem hiding this comment.
Functionality seems to work, and I checked that the new subscriptions were being disposed (they are). What I didn't check is that bundling works, so if you could confirm that there's no issues with bundling, then we should e good to go for the UI portion of this functiion.
m0nhawk
pushed a commit
to uc-cdis/Atlas
that referenced
this pull request
Nov 1, 2021
* Assets Tags implementation * Assets Tags implementation * Assets Tags implementation * Assets Tags implementation * Assets Tags implementation * Assets Tags implementation * Assets Tags i18n * Assets Tags implementation - show faceted-table buttons for cc and pathways * Assets Tags implementation - messages fixes * Assets Tags implementation - tag reassign confirmation added * Assets Tags implementation - 'custom tag already exists' message fix * Tags improvement - header tooltips * Tags implementation - Atlas Phase 1 Fixes * Tags implementation - Atlas Phase 1 Fixes - only 5 lines in tables * Tags implementation - Atlas Phase 1 Fixes - add dynamic tag columns default width * Tags implementation - Atlas Phase 1 Fixes * Fix - remove unused observable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: OHDSI/WebAPI#1917
Backend PR: OHDSI/WebAPI#1914