fix: GitHub changed markdown rendering for headings/anchors#3548
Merged
darrelmiller merged 1 commit intoOAI:mainfrom Feb 13, 2024
Merged
fix: GitHub changed markdown rendering for headings/anchors#3548darrelmiller merged 1 commit intoOAI:mainfrom
darrelmiller merged 1 commit intoOAI:mainfrom
Conversation
Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com>
This was referenced Feb 2, 2024
Member
Author
|
So, what's going on here is this (all done by a script written by Mike Ralphson):
You can see the rendered result at https://github.com/handrews/OpenAPI-Specification/tree/anchor-fixes/versions I've skimmed through these and it looks like the updates are correct. I skimmed slowly enough for 3.1.1 that I am fairly sure nothing else was touched (except trimming a bit of trailing whitespace on some lines, which is fine). |
This was referenced Feb 10, 2024
darrelmiller
approved these changes
Feb 13, 2024
handrews
added a commit
to handrews/OpenAPI-Specification
that referenced
this pull request
Oct 11, 2024
Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com> Co-authored-by: Mike Ralphson <mike.ralphson@gmail.com>
This was referenced Oct 14, 2024
frantuma
added a commit
to swagger-api/swagger-core
that referenced
this pull request
Jan 6, 2025
frantuma
added a commit
to swagger-api/swagger-core
that referenced
this pull request
Jan 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rebase/re-submit of @MikeRalphson's exact commit from PR #3408 as he is not currently available to rebase it (the markdown checks were broken at that point on main- they should be fixed now).
Here is that PR's text:
Closes #3207 #3160 #3136 #3128 #3029 #3197 #3132
This PR mechanically corrects for the change made by GitHub to its markdown renderer which no longer honours the mixed markdown/html form:
### <a name="myAnchor"></a> My Anchor(the use of
nameoridmakes no difference), and only links to the implicit anchor#my-anchornow work.This PR affects the
mainbranch, so published versions of the OAS only. If merged, follow-up PRs will be raised for in-flight-devbranch versions.An example of the result of this PR can be previewed here. [Note: points to @handrews's fork because of the re-submit]