Fix MonoBehaviour custom counter menu binding#141
Merged
NuggoDEV merged 1 commit intoNuggoDEV:masterfrom Aug 19, 2024
Merged
Conversation
rakkyo150
pushed a commit
to rakkyo150/CounterPlus-Improved
that referenced
this pull request
Nov 2, 2025
Fix MonoBehaviour custom counter menu binding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FromComponentOnRootrequires the object to already exist on the root, which is not correct in this case. The settings menu should be created here.Use a new game object instead of root to allow Zenject to run the inject methods before enabling the MonoBehaviour.
Changes to type checks cover the cases where the type is not directly inheriting
MonoBehaviour(there are more layers in between).