Skip to content

added getfiles#76

Closed
zhili1208 wants to merge 3 commits intodevfrom
packageFile
Closed

added getfiles#76
zhili1208 wants to merge 3 commits intodevfrom
packageFile

Conversation

@zhili1208
Copy link
Copy Markdown
Contributor

added GetFiles method to ScriptPackage.
NuGet/Home#863

@zhili1208
Copy link
Copy Markdown
Contributor Author

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename this since it is now more specific to scripted packages

@emgarten
Copy link
Copy Markdown
Contributor

emgarten commented Sep 4, 2015

@MeniZalzman
Copy link
Copy Markdown
Contributor

@zhili1208 did you merge this PR? if so can you please close it

@zhili1208
Copy link
Copy Markdown
Contributor Author

not yet

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not getting all the files in the package, is this compatible with 2.8 ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will get all files in the package, the last one get all unknow files, it's compatible with 2.8

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please break long line. In particular, lines of a LINQ query should be broken at the clause as follows

reader.GetFiles()
.Where(...)
.Select(...)

@deepakaravindr
Copy link
Copy Markdown
Contributor

⌚ (Just looked at this PR for the first time, will sign-off in the next iteration)

zhili1208 added a commit to NuGet/NuGet.Client that referenced this pull request Oct 14, 2015
@zhili1208 zhili1208 closed this Oct 14, 2015
@zhili1208 zhili1208 deleted the packageFile branch October 19, 2015 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants