Conversation
donnie-msft
approved these changes
Jan 7, 2026
martinrrm
approved these changes
Jan 7, 2026
Nigusu-Allehu
pushed a commit
that referenced
this pull request
Jan 26, 2026
Nigusu-Allehu
added a commit
that referenced
this pull request
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: engineering
Description
The PR #7023 has an error, which wasn't caught because the step only runs on official builds, not PR builds.
I also removed the conditions on IsOfficial, so that the pull request build validates more of what the official build does. These types of errors should be caught before getting merged.
PR Checklist
and a linked NuGet/Home issueAdded testsLink to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.