Skip to content

Improve CI drop management#6869

Merged
zivkan merged 8 commits intorelease/7.0.xfrom
dev-zivkan-optprof-drop-url
Oct 23, 2025
Merged

Improve CI drop management#6869
zivkan merged 8 commits intorelease/7.0.xfrom
dev-zivkan-optprof-drop-url

Conversation

@zivkan
Copy link
Member

@zivkan zivkan commented Oct 17, 2025

Bug

Fixes: Infrastructure

Description

Really fixes OptProf for release/* branches, also makes all drops URLs have a single source of truth, and all other references programmatically calculate the URL. Includes other minor improvements

  • The build CI's "Build Insertable" job defines variables for drop names it uses, so the variable can be shared instead of recalculated over and over.
  • Stop building the VS bootstrapper. All the DartLab pipelines create their own bootstrapper, so this pipeline doesn't need to.
  • Fix sending the SigningType parameter to the signing step, so test signing on the official pipeline actually works.

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests N/A
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc. N/A

@zivkan zivkan requested a review from a team as a code owner October 17, 2025 10:43
@zivkan zivkan requested review from jebriede and nkolev92 October 17, 2025 10:44
Copy link
Member

@Nigusu-Allehu Nigusu-Allehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Nigusu-Allehu
Copy link
Member

I think we need to insert the warning as error fixes into release/7.0.x first.

@zivkan zivkan merged commit f136aa0 into release/7.0.x Oct 23, 2025
15 of 18 checks passed
@zivkan zivkan deleted the dev-zivkan-optprof-drop-url branch October 23, 2025 19:22
zivkan added a commit that referenced this pull request Oct 24, 2025
@zivkan zivkan mentioned this pull request Oct 24, 2025
3 tasks
zivkan added a commit that referenced this pull request Oct 24, 2025
zivkan added a commit that referenced this pull request Oct 24, 2025
zivkan added a commit that referenced this pull request Oct 24, 2025
zivkan added a commit that referenced this pull request Oct 24, 2025
zivkan added a commit that referenced this pull request Oct 24, 2025
zivkan added a commit that referenced this pull request Oct 24, 2025
zivkan added a commit that referenced this pull request Oct 24, 2025
jeffkl pushed a commit that referenced this pull request Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants