Skip to content

CI pipelines should work when branch has slash#6853

Merged
zivkan merged 2 commits intodevfrom
dev-zivkan-fix-OptProf
Oct 14, 2025
Merged

CI pipelines should work when branch has slash#6853
zivkan merged 2 commits intodevfrom
dev-zivkan-fix-OptProf

Conversation

@zivkan
Copy link
Member

@zivkan zivkan commented Oct 13, 2025

Bug

Fixes: https://github.com/NuGet/Client.Engineering/issues/3483

Description

There were several places our CI scripts look like it would either fail, or produce incorrect results, when a branch name has a slash (for example release/7.x). This PR tries to fix all of them.

  • The OptProf pipeline was failing on the release/* branch, because the runsettings drop name was wrong. Fixed the build pipeline to publish it to the expected name
  • ConfigureVstsBuild.ps1 writes the branch name to BuildInfo.json, and it was writing a branch name that doesn't exist.
  • When publishing to BAR, we were telling it a branch name that doesn't exist.
  • Our init steps of the build were tagging the builds with the commit author name and branch name. I don't believe these tags are useful, so I'm removing them. The branch name in particular is already visible in the Azure Pipelines GUI.
  • Changing the OneLocBuild branch name. I don't know much about this process, but considering the input name is MirrorBranch, it feels to me like it should match the full name, not the substring after the last /.
  • I'm changing where the product gets published, so I'll need to update the release pipeline and all servicing branches with this change.

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests N/A
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc. N/A

@zivkan zivkan requested a review from a team as a code owner October 13, 2025 22:40
@zivkan zivkan requested review from jebriede and nkolev92 October 13, 2025 22:40
@zivkan zivkan marked this pull request as draft October 13, 2025 22:44
@zivkan zivkan marked this pull request as ready for review October 14, 2025 03:18
@zivkan zivkan merged commit f650f59 into dev Oct 14, 2025
17 of 18 checks passed
@zivkan zivkan deleted the dev-zivkan-fix-OptProf branch October 14, 2025 23:47
@zivkan
Copy link
Member Author

zivkan commented Oct 14, 2025

/backport to release/7.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants