Skip to content

Configure SBOM for Build pipeline#6333

Merged
donnie-msft merged 2 commits intodevfrom
dev-donnie-msft-genSbomLite
Mar 21, 2025
Merged

Configure SBOM for Build pipeline#6333
donnie-msft merged 2 commits intodevfrom
dev-donnie-msft-genSbomLite

Conversation

@donnie-msft
Copy link
Copy Markdown
Contributor

@donnie-msft donnie-msft commented Mar 20, 2025

Bug

Fixes:

Description

In order to migrate to 1ES PT Release templates, our build must create artifacts with an SBOM to be compliant.

  1. Enable SBOM for official builds and explicitly set the sbomBuildDropPath.
  2. Stop using a special directory (/sbom) as the release templates do not support looking for these in subdirectories of the artifacts.
    This prevents errors like this:
    "Could not find a part of the path 'D:\a_work\1\nupkgs - RTM_manifest\spdx_2.2\manifest.spdx.json'."
  3. Disabled SBOM on tasks that generate artifacts that we do not release.
  4. PR Builds have SBOM generation enabled to validate any issues generating SBOMs prior to starting official builds. (Feedback from @zivkan )

Servicing branches

My plan is to make the same change on all servicing branches after merged to dev.

Validation

Tested in our new release pipeline. Eg, see 6.14.0.85-2 as a recent example of the VS Insertion successfully finding these SBOM artifacts.

Tested our existing release pipeline to ensure it still completes with changes from this PR. It created this PR (which I abandoned): https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/621001.

PR Checklist

@donnie-msft donnie-msft requested a review from a team as a code owner March 20, 2025 19:20
@donnie-msft donnie-msft changed the title aConfigure SBOM for Build pipeline Configure SBOM for Build pipeline Mar 20, 2025
jeffkl
jeffkl previously approved these changes Mar 20, 2025
@donnie-msft donnie-msft added the Engineering Changes related to the build infrastructure of the repo and that do not change product code label Mar 20, 2025
Comment thread eng/common/templates/steps/generate-sbom.yml
@donnie-msft donnie-msft requested a review from zivkan March 20, 2025 22:47
@donnie-msft donnie-msft merged commit 73bd9f4 into dev Mar 21, 2025
23 checks passed
@donnie-msft donnie-msft deleted the dev-donnie-msft-genSbomLite branch March 21, 2025 20:39
donnie-msft added a commit that referenced this pull request Mar 24, 2025
donnie-msft added a commit that referenced this pull request Mar 24, 2025
donnie-msft added a commit that referenced this pull request Mar 24, 2025
donnie-msft added a commit that referenced this pull request Mar 24, 2025
donnie-msft added a commit that referenced this pull request Mar 24, 2025
donnie-msft added a commit that referenced this pull request Mar 24, 2025
donnie-msft added a commit that referenced this pull request May 6, 2025
donnie-msft added a commit that referenced this pull request Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Engineering Changes related to the build infrastructure of the repo and that do not change product code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants