Merged
Conversation
jeffkl
previously approved these changes
Mar 20, 2025
zivkan
reviewed
Mar 20, 2025
jeffkl
approved these changes
Mar 21, 2025
donnie-msft
added a commit
that referenced
this pull request
Mar 24, 2025
donnie-msft
added a commit
that referenced
this pull request
Mar 24, 2025
donnie-msft
added a commit
that referenced
this pull request
Mar 24, 2025
donnie-msft
added a commit
that referenced
this pull request
Mar 24, 2025
donnie-msft
added a commit
that referenced
this pull request
Mar 24, 2025
donnie-msft
added a commit
that referenced
this pull request
Mar 24, 2025
donnie-msft
added a commit
that referenced
this pull request
May 6, 2025
This was referenced May 6, 2025
donnie-msft
added a commit
that referenced
this pull request
May 7, 2025
donnie-msft
added a commit
that referenced
this pull request
May 7, 2025
donnie-msft
added a commit
that referenced
this pull request
May 7, 2025
donnie-msft
added a commit
that referenced
this pull request
May 7, 2025
donnie-msft
added a commit
that referenced
this pull request
Jul 12, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes:
Description
In order to migrate to 1ES PT Release templates, our build must create artifacts with an SBOM to be compliant.
sbomBuildDropPath./sbom) as the release templates do not support looking for these in subdirectories of the artifacts.This prevents errors like this:
"Could not find a part of the path 'D:\a_work\1\nupkgs - RTM_manifest\spdx_2.2\manifest.spdx.json'."
Servicing branches
My plan is to make the same change on all servicing branches after merged to
dev.Validation
Tested in our new release pipeline. Eg, see
6.14.0.85-2as a recent example of the VS Insertion successfully finding these SBOM artifacts.Tested our existing release pipeline to ensure it still completes with changes from this PR. It created this PR (which I abandoned): https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/621001.
PR Checklist