Add --configfile option to dotnet nuget push command#6286
Merged
Conversation
jeffkl
approved these changes
Feb 25, 2025
nkolev92
approved these changes
Feb 25, 2025
Member
nkolev92
left a comment
There was a problem hiding this comment.
Does this need an SDK side change?
Nigusu-Allehu
approved these changes
Feb 26, 2025
Contributor
Author
|
@nkolev92 created an SDK PR for this dotnet/sdk#47126, I'm not sure if that's all the changes needed. Can I merge this one now and continue that conversation on the other PR? |
zivkan
approved these changes
Feb 26, 2025
Member
zivkan
left a comment
There was a problem hiding this comment.
The PR checklist says that a docs issue is linked, but there is no link to a docs issue
Member
Oh yeah, I think these PRs can be merged out of order. |
Contributor
Author
|
@zivkan created a docs PR in the dotnet repo dotnet/docs#45050 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#4879
Docs PR: dotnet/docs#45050
Description
Adds the option
--configfileto the command dotnet nuget push. Other commands also useXPlatUtility.ProcessConfigFileto get the config file, if no value is passed it will default toXPlatUtility.GetSettingsForCurrentWorkingDirectory()which is the current implementation.PR Checklist