Skip to content

Add --configfile option to dotnet nuget push command#47126

Merged
baronfel merged 1 commit intomainfrom
dev-martinrrm-configfile-option-dotnet-nuget-push
Feb 26, 2025
Merged

Add --configfile option to dotnet nuget push command#47126
baronfel merged 1 commit intomainfrom
dev-martinrrm-configfile-option-dotnet-nuget-push

Conversation

@martinrrm
Copy link
Copy Markdown
Contributor

Fixes: NuGet/Home#4879

NuGet is adding the option --configfile to the command dotnet nuget push. This PR adds the option to the command and updates the autocomplete tests.

Copilot AI review requested due to automatic review settings February 26, 2025 05:26
@martinrrm martinrrm requested a review from a team as a code owner February 26, 2025 05:26
@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Feb 26, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@nkolev92
Copy link
Copy Markdown
Contributor

Do we want this in 9.0.3xx as well?
Considering that's where I code will end-up first?

@marcpopMSFT How high is the bar for 9.0.3xx?
We're adding this option to the push command and the only benefit from putting in the SDK parsing as well is the fact that we get autocomplete.

@baronfel
Copy link
Copy Markdown
Member

Additions, especially to commands you control, easily meet the bar. I don't think SDK is locked yet for 300.

@baronfel
Copy link
Copy Markdown
Member

We can get this merged and a backport PR created easily to surface the option.

@martinrrm
Copy link
Copy Markdown
Contributor Author

@baronfel Is it good if I merge now? Also, how does the backporting PR works?

@baronfel baronfel merged commit 3b0113a into main Feb 26, 2025
42 checks passed
@baronfel baronfel deleted the dev-martinrrm-configfile-option-dotnet-nuget-push branch February 26, 2025 19:31
@baronfel
Copy link
Copy Markdown
Member

/backport to release/9.0.3xx

@github-actions
Copy link
Copy Markdown
Contributor

Started backporting to release/9.0.3xx: https://github.com/dotnet/sdk/actions/runs/13551885949

@github-actions
Copy link
Copy Markdown
Contributor

@baronfel an error occurred while backporting to "release/9.0.3xx", please check the run log for details!

The process '/usr/bin/git' failed with exit code 1

@baronfel
Copy link
Copy Markdown
Member

/backport to release/9.0.3xx

1 similar comment
@baronfel
Copy link
Copy Markdown
Member

/backport to release/9.0.3xx

@github-actions
Copy link
Copy Markdown
Contributor

Started backporting to release/9.0.3xx: https://github.com/dotnet/sdk/actions/runs/13551914583

@github-actions
Copy link
Copy Markdown
Contributor

Started backporting to release/9.0.3xx: https://github.com/dotnet/sdk/actions/runs/13551916250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dotnet-nuget-push: does not support --config-file included in examples

7 participants