Merged
Conversation
dominoFire
previously approved these changes
Aug 24, 2022
nkolev92
previously approved these changes
Aug 25, 2022
zivkan
reviewed
Aug 25, 2022
Comment on lines
+14
to
+15
| <TargetPlatformVersion Condition=" '$(TargetPlatformVersion)' == '' ">10.0.19041.0</TargetPlatformVersion> | ||
| <TargetPlatformMinVersion>10.0.17763.0</TargetPlatformMinVersion> |
Member
There was a problem hiding this comment.
I didn't look into the CI failures, but be careful about changing these values. One of the two values determines which version of the Windows SDK VS will look for on the machine, and if that version of the Windows SDK isn't defined in the vsconfig file that the DartLab machine uses for configuration, VS will pop up a dialog that will freeze the test until the test, or the entire pipeline, times out.
Contributor
Author
There was a problem hiding this comment.
Good catch! Thanks! Fixed.
f8e46ea to
0578302
Compare
jeffkl
approved these changes
Aug 30, 2022
dominoFire
approved these changes
Aug 30, 2022
Contributor
dominoFire
left a comment
There was a problem hiding this comment.
Maybe we can use dotnet new to create new test projects on the fly.
jeffkl
reviewed
Aug 30, 2022
| # Arrange | ||
| $project1 = New-ClassLibrary | ||
| $project1 | Install-Package Newtonsoft.Json -Version 5.0.6 | ||
| $project1 | Install-Package Newtonsoft.Json -Version 13.0.1 |
Contributor
There was a problem hiding this comment.
Is it easy to declare a version variable so this can be updated in one place next time if needed?
nkolev92
pushed a commit
that referenced
this pull request
Sep 29, 2023
nkolev92
pushed a commit
that referenced
this pull request
Sep 29, 2023
nkolev92
pushed a commit
that referenced
this pull request
Sep 29, 2023
nkolev92
added a commit
that referenced
this pull request
Oct 2, 2023
* Update dependencies in E2E tests (#4767) * Fix component detection alert for microsoft.owin package (#4841) * Remove package for Microsoft.Owin in End2end test * Address component detection failure newtonsoft.json 4.0.1 (#4934) * remove unused Moq package from E2E test (#5358) --------- Co-authored-by: Heng Liu <45407901+heng-liu@users.noreply.github.com> Co-authored-by: Erick Yondon <eryondon@microsoft.com> Co-authored-by: Martin Ruiz <martin.ruiz.mares@gmail.com>
nkolev92
added a commit
that referenced
this pull request
Oct 2, 2023
* Update dependencies in E2E tests (#4767) * Fix component detection alert for microsoft.owin package (#4841) * Remove package for Microsoft.Owin in End2end test * Address component detection failure newtonsoft.json 4.0.1 (#4934) * remove unused Moq package from E2E test (#5358) * Use net6.0-windows --------- Co-authored-by: Heng Liu <45407901+heng-liu@users.noreply.github.com> Co-authored-by: Erick Yondon <eryondon@microsoft.com> Co-authored-by: Martin Ruiz <martin.ruiz.mares@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/1818
Regression? Last working version:
Description
Update the dependency versions in E2E tests.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation