Conversation
|
blocked on dotnet/sdk#19440 |
| <IncludeInVSIX>true</IncludeInVSIX> | ||
| </Content> | ||
| <Content Include="$(SolutionPackagesFolder)newtonsoft.json\9.0.1\lib\net45\Newtonsoft.Json.dll"> | ||
| <Content Include="$(SolutionPackagesFolder)newtonsoft.json\13.0.1\lib\net45\Newtonsoft.Json.dll"> |
There was a problem hiding this comment.
nit: You can use the newtonsoft version variable.
There was a problem hiding this comment.
The MSBuild property with the version number is defined in packages.targets which is imported after this line. I don't feel like spending time moving imports around to get this working without causing problems.
There was a problem hiding this comment.
Content is an item, but the version number is a property.
Property pass happens before the items pass, so the ordering wouldn't matter.
There was a problem hiding this comment.
Are you sure properties are evaluated before items? I thought MSBuild was strictly "top down"
There was a problem hiding this comment.
There was a problem hiding this comment.
I'll try to remember for the cleanup issue.
There was a problem hiding this comment.
Only do that if you want to.
I don't want these comments to add any additional work.
It's nice to have, but really not that important in the grand scheme.
| <Authenticode>3PartySHA2</Authenticode> | ||
| </FilesToSign> | ||
| <FilesToSign Include="$(SolutionPackagesFolder)newtonsoft.json\9.0.1\lib\net45\Newtonsoft.Json.dll"> | ||
| <FilesToSign Include="$(SolutionPackagesFolder)newtonsoft.json\13.0.1\lib\net45\Newtonsoft.Json.dll"> |
There was a problem hiding this comment.
nit: You can use the newtonsoft version variable.
There was a problem hiding this comment.
This proj file doesn't currently import package.targets, and while it wouldn't be difficult to do so, I don't feel like spinning another build.
| } | ||
| } | ||
|
|
||
| // temp: delete once the .NET SDK ships Newtonsoft.Json 13.0.1 or higher |
There was a problem hiding this comment.
I'm not going to spin another build just to change the comment.
Bug
Fixes: NuGet/Home#11095
Regression? no
Description
Update package version, and do some cleanup.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation