Change services to local and remote exclusive only#3710
Conversation
|
@sbanni - i looked for docs on that enum...but doesn't do much explaining... can you point towards some descriptions of those different choices...and why you chose what you did. |
@rrelyea Best place to find the descriptions for these values is in the code: |
|
RemoteExclusiveClient sounds like we should disable it as well. Perhaps double check with Andrew? (doc comments still have room for improvement...to make clearer) |
|
from scott: |
| [ProvideBrokeredService(BrokeredServicesUtilities.SolutionManagerServiceName, BrokeredServicesUtilities.SolutionManagerServiceVersion, Audience = ServiceAudience.AllClientsIncludingGuests)] | ||
| [ProvideBrokeredService(BrokeredServicesUtilities.ProjectManagerServiceName, BrokeredServicesUtilities.ProjectManagerServiceVersion, Audience = ServiceAudience.AllClientsIncludingGuests)] | ||
| [ProvideBrokeredService(BrokeredServicesUtilities.ProjectUpgraderServiceName, BrokeredServicesUtilities.ProjectUpgraderServiceVersion, Audience = ServiceAudience.AllClientsIncludingGuests)] | ||
| [ProvideBrokeredService(BrokeredServicesUtilities.SourceProviderServiceName, BrokeredServicesUtilities.SourceProviderServiceVersion, Audience = ServiceAudience.Local | ServiceAudience.RemoteExclusiveClient)] |
There was a problem hiding this comment.
No, those services are only used in the VS.Oe scenario.
Bug
Fixes: NuGet/Home#10117
Fix
Details: Remove LiveShare support for our brokered services
Testing/Validation
Tests Added: No
Validation: Installed locally and tested local (same process) and local remote, same machine two instances of devenv, one server one client. Verified Tools -> Options worked and PM UI scenarios including installing/updating/uninstalling packages.