obsolete PackageSource related types from earlier in 5.8#3698
Merged
Conversation
nkolev92
approved these changes
Oct 1, 2020
Member
|
@rrelyea You might not want to say "Fixes", because it will auto close the issue. We probably need another issue for adding the obsolete flag on these APIs and keep an issue as a follow to remove them. |
dominoFire
approved these changes
Oct 1, 2020
Contributor
|
Looks like need to suppress CS0618 in some other files? |
sbanni
approved these changes
Oct 1, 2020
rrelyea
pushed a commit
that referenced
this pull request
Oct 1, 2020
* obsolete PackageSource related types from earlier in 5.8 * add pragmas to allow calling obsolete apis for now. * additional pragmas (cherry picked from commit b987ca9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
related to NuGet/Home#10098
Regression: No
Fix
Details: Obsolete a few apis that were added earlier in 5.8, to avoid customers from using them.
Testing/Validation
Tests Added: No
Validation: will validate insertion build to ensure tools/options/package sources still works in codespaces and non-codespaces.